Add "Commited x units ago" to changeset viewer

[mcarpenter@…]

Many other places (roadmap for one) in trac show time like "3 months ago". It would be nice if the changeset viewer also did this. So the timestamp for [1] would show:

Timestamp: 11/22/05 16:57:13 (3 months ago)

[Christian Boos]

Here you are:

templates/changeset.cs

@@ -102 +102 @@
 
 <dl id="overview">
  <dt class="time">Timestamp:</dt>
- <dd class="time"><?cs var:changeset.time ?></dd>
+ <dd class="time"><?cs var:changeset.time ?> (<?cs var:changeset.age ?> ago)</dd>
  <dt class="author">Author:</dt>
  <dd class="author"><?cs var:changeset.author ?></dd>
  <dt class="message">Message:</dt>

trac/versioncontrol/web_ui/changeset.py

@@ -153 +153 @@
         req.hdf['changeset'] = {
             'revision': chgset.rev,
             'time': util.format_datetime(chgset.date),
+            'age': util.pretty_timedelta(chgset.date),
             'author': util.escape(chgset.author or 'anonymous'),
             'message': wiki_to_html(chgset.message or '--', self.env, req,
                                     escape_newlines=True)

[Christopher Lenz]

You'd also have to completely remove the caching support (req.check_modified()).

[Christian Boos]

Ah yes, didn't think about that. But maybe the cacheing can be improved by sending a hash key that has been computed from all the elements that are susceptible to change:

• youngest rev or not
• "pretty" time (as per this ticket)
• commit log message (as per #781)

[Christian Boos]

Implements the feature, while being cache friendly

[Christian Boos]

The attachment:T2451-for-r2625.patch​ does what I suggested above.

In addition, the (… ago) message will be (less than one hour ago) for recent changes, which is more cache friendly.

Now that I think about it, I should have added repos.name to the mix, as this would additionally trigger a reload in the case of a switch to another repository, even if the change only affects the scope of the repository.

[Christian Boos]

Ok with the changes?

[Christian Boos]

Reviewed patch applied in r2636.