Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

#2430 closed defect (fixed)

Milestone progess bars don't fill their bounding box

Reported by: markus Owned by: Christopher Lenz
Priority: normal Milestone: 0.9.4
Component: roadmap Version: 0.9
Severity: normal Keywords: layout
Cc: Branch:
Release Notes:
API Changes:

Description

[2411] led to another layout issue as the inner progress bars (completed & new/assigned/reopened) never fill the complete bounding box. This is ugly and confusing since there's a region on the right of your progress bar where you can "see through" the bar and that doesn't link to any query.

This issue is reproducible with any Trac 0.9+ installation on any browser I tested so far (Firefox, Mozilla, Opera, Internet Explorer).

Attachments (1)

2430-1.diff (7.4 KB ) - added by markus 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by markus, 14 years ago

This worksformarkus! ;-)

  • htdocs/css/roadmap.css

     
    55 border: none;
    66 display: block;
    77 float: left;
     8 clear: right;
    89 height: 1.2em;
    910}
    1011div.progress :link:hover, div.progress :visited:hover { background: #fff }
  • templates/milestone.cs

     
    126126        if:#stats.total_tickets != #1 ?>s<?cs /if ?> closed"></a>
    127127      <a class="open" href="<?cs
    128128        var:milestone.queries.active_tickets ?>" style="width: <?cs
    129         var:#stats.percent_active - 1 ?>%" title="<?cs
     129        var:#stats.percent_active ?>%" title="<?cs
    130130        var:#stats.active_tickets ?> of <?cs
    131131        var:#stats.total_tickets ?> ticket<?cs
    132132        if:#stats.total_tickets != #1 ?>s<?cs /if ?> active"></a>
  • templates/roadmap.cs

     
    4646         if:#stats.total_tickets != #1 ?>s<?cs /if ?> closed"></a>
    4747       <a class="open" href="<?cs
    4848         var:milestone.queries.active_tickets ?>" style="width: <?cs
    49          var:#stats.percent_active - 1 ?>%" title="<?cs
     49         var:#stats.percent_active ?>%" title="<?cs
    5050         var:#stats.active_tickets ?> of <?cs
    5151         var:#stats.total_tickets ?> ticket<?cs
    5252         if:#stats.total_tickets != #1 ?>s<?cs /if ?> active"></a>

See also #1886.

comment:2 by Christopher Lenz, 14 years ago

Keywords: layout added
Milestone: 0.9.2
Status: newassigned

Will look into this.

comment:3 by Christopher Lenz, 14 years ago

Milestone: 0.9.30.9.4

by markus, 14 years ago

Attachment: 2430-1.diff added

comment:4 by markus, 14 years ago

After talking to cmlenz we decided to fix this ticket another way. The patch I just attached is a preview of my proposal. Unfortunately the final version won't be finished for the next release, sorry… :(

comment:5 by Christopher Lenz, 14 years ago

Resolution: fixed
Status: assignedclosed

Applied a slightly modified version of the patch in [2906] and [2907]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.