Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

#2408 closed defect (fixed)

Email notification to reporters is broken

Reported by: dbrocher@… Owned by: Emmanuel Blot
Priority: high Milestone: 0.9.4
Component: ticket system Version: 0.9
Severity: normal Keywords: email notification reporter
Cc: dbrocher@… Branch:
Release Notes:
API Changes:

Description

Setting always_notify_reporter = true is meant to send notification emails for ticket changes to the original author of the ticket and also every author of a ticket change. The latter doesn't work in version 0.9. The bug has been introduced in changeset [1343], where the following code starting at line 294 in Notify.py

    cursor.execute('SELECT DISTINCT author,ticket FROM ticket_change ' 
                   ' WHERE ticket=%s', tktid) 
    rows = cursor.fetchall() 
    for row in rows: 
        emails += row[0] and self.get_email_addresses(row[0]) or [] 

has been replaced with (starting at line 310 in Notify.py)

    cursor.execute("SELECT DISTINCT author,ticket FROM ticket_change " 
                   "WHERE ticket=%s", (tktid,)) 
    for author,ticket in cursor: 
        recipients.append(row[0]) 

In the last line, row[0] should be replaced with author.

Attachments (1)

Ticket_2408.patch (484 bytes ) - added by dbrocher@… 14 years ago.
This patch fixes the problem in the trunk at the current revision 2569

Download all attachments as: .zip

Change History (8)

by dbrocher@…, 14 years ago

Attachment: Ticket_2408.patch added

This patch fixes the problem in the trunk at the current revision 2569

comment:1 by anonymous, 14 years ago

Owner: changed from Jonas Borgström to anonymous

comment:2 by anonymous, 14 years ago

Owner: changed from anonymous to dbrocher@…

comment:3 by anonymous, 14 years ago

Owner: changed from dbrocher@… to Jonas Borgström

comment:4 by dbrocher@…, 14 years ago

Milestone: 0.9.3

I think this should be fixed in the next milestone. Thanks.

comment:5 by Emmanuel Blot, 14 years ago

Owner: changed from Jonas Borgström to Emmanuel Blot
Status: newassigned

Already fixed in the notification sandbox [2519]. I think (hope) this will effectively be commited to the trunk for 0.9.3

comment:6 by anonymous, 14 years ago

Milestone: 0.9.30.9.4

comment:7 by Emmanuel Blot, 14 years ago

Resolution: fixed
Status: assignedclosed

Should be fixed in [2799] for 0.10
Should be fixed in [2823] for 0.9

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Emmanuel Blot.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Emmanuel Blot to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.