Milestone progress graph

[Barclay]

When symbol "&" is used in name of milestone, progress graph is not shown for it in list of milestones. To get that list, click on Roadmap menu item.

[markus]

The problem is that in RoadmapModule.process_request() milestone['name'] gets escaped by milestone_to_hdf() and so passed to get_tickets_for_milestone() as e.g. Mile&stone. Consequently, the database queries in get_tickets_for_milestone() and get_query_links() fail in finding Mile&stone.

trac/ticket/roadmap.py

@@ -20 +20 @@
 from trac import __version__
 from trac.core import *
 from trac.perm import IPermissionRequestor
-from trac.util import escape, format_date, format_datetime, parse_date, \
-                      pretty_timedelta, shorten_line, CRLF
+from trac.util import escape, unescape, format_date, format_datetime, \
+                      parse_date, pretty_timedelta, shorten_line, CRLF
 from trac.ticket import Milestone, Ticket, TicketSystem
 from trac.Timeline import ITimelineEventProvider
 from trac.web import IRequestHandler
@@ -29 +29 @@
 from trac.wiki import wiki_to_html, wiki_to_oneliner, IWikiSyntaxProvider
 
 def get_tickets_for_milestone(env, db, milestone, field='component'):
+    milestone = unescape(milestone)
     cursor = db.cursor()
     fields = TicketSystem(env).get_ticket_fields()
     if field in [f['name'] for f in fields if not f.get('custom')]:
@@ -45 +46 @@
 
 def get_query_links(env, milestone, grouped_by='component', group=None):
     q = {}
+    milestone = unescape(milestone)
     if not group:
         q['all_tickets'] = env.href.query(milestone=milestone)
         q['active_tickets'] = env.href.query(milestone=milestone,

[Christopher Lenz]

Fixed in [2582] and [2583].