Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#2330 closed defect (fixed)

summary href URL not correctly rendered if not t.id in the query

Reported by: alessandro.ogier@… Owned by: Christopher Lenz
Priority: low Milestone: 0.9.4
Component: report system Version: 0.9
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

if the custom query does not SELECT ticket.id, the href of every ticket summary will be the report page itself.

to reproduce, create a custom report with an appropriate select query.

Attachments (0)

Change History (6)

comment:1 by alessandro.ogier@…, 14 years ago

a simple, not too intrusive workaround would be :

--- report_original.py  2005-11-10 00:44:01.608853132 +0100
+++ report.py   2005-11-10 00:46:12.778042759 +0100
@@ -338,9 +338,9 @@
                 elif column[0] == '_':
                     value['hidehtml'] = 1
                     column = column[1:]
-                if column in ['id', 'ticket', '#', 'summary']:
+                if column in ['id', '_id', 'ticket', '#', 'summary']:
                     id_cols = [idx for idx, col in util.enum(cols)
-                               if col[0] in ('ticket', 'id')]
+                               if col[0] in ('ticket', 'id', '_id')]
                     if id_cols:
                         id_val = row[id_cols[0]]
                         value['ticket_href'] = self.env.href.ticket(id_val)

so

                    if id_cols:
                        id_val = row[id_cols[0]]
                        value['ticket_href'] = self.env.href.ticket(id_val)

doesn't break

comment:2 by anonymous, 14 years ago

Priority: normalhigh
Severity: majorblocker

comment:3 by Christopher Lenz, 14 years ago

Priority: highnormal
Severity: blockermajor

comment:4 by alessandro.ogier@…, 14 years ago

Priority: normalhigh

so no fix even in the 0.9.3 :|

ehi, there's already a patch, it's a BIG PAIN to manually patch sources every upgrade i do :(

comment:5 by Christopher Lenz, 14 years ago

Milestone: 0.9.4
Owner: changed from daniel to Christopher Lenz
Priority: highlow
Severity: majorminor
Status: newassigned

comment:6 by Christopher Lenz, 14 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [2895] and [2896].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.