summary href URL not correctly rendered if not t.id in the query

[alessandro.ogier@…]

if the custom query does not SELECT ticket.id, the href of every ticket summary will be the report page itself.

to reproduce, create a custom report with an appropriate select query.

[alessandro.ogier@…]

a simple, not too intrusive workaround would be :

--- report_original.py  2005-11-10 00:44:01.608853132 +0100
+++ report.py   2005-11-10 00:46:12.778042759 +0100
@@ -338,9 +338,9 @@
                 elif column[0] == '_':
                     value['hidehtml'] = 1
                     column = column[1:]
-                if column in ['id', 'ticket', '#', 'summary']:
+                if column in ['id', '_id', 'ticket', '#', 'summary']:
                     id_cols = [idx for idx, col in util.enum(cols)
-                               if col[0] in ('ticket', 'id')]
+                               if col[0] in ('ticket', 'id', '_id')]
                     if id_cols:
                         id_val = row[id_cols[0]]
                         value['ticket_href'] = self.env.href.ticket(id_val)

so

                    if id_cols:
                        id_val = row[id_cols[0]]
                        value['ticket_href'] = self.env.href.ticket(id_val)

doesn't break

[alessandro.ogier@…]

so no fix even in the 0.9.3 :|

ehi, there's already a patch, it's a BIG PAIN to manually patch sources every upgrade i do :(

[Christopher Lenz]

Fixed in [2895] and [2896].