#!diff preview in wiki hides previous line

[anonymous]

Rendering Wiki Preview with #!diff from IE6(WinXP), diff outputs hide previous line. Firefox 1.0.7 does not have this problem.

= header 1 =
this is content1.
== header 2 ==
this is content2.
{{{
#!diff
 ... some unified diff
}}}

Preview at wiki, "this is content2." overlapped diff output. After submit this, "this is content2." line can see even if I saw this page by IE6.

[sid]

Does this only happen for the preview, but not the normal saved page rendering?

[anonymous]

header 1

this is content1.

header 2

this is content2.

 ... some unified diff

[anonymous]

header 1

this is content1.

header 2

this is content2.

trac/ticket/web_ui.py

@@ -461 +461 @@
             ticket = ctx.shortname() + ': '
             if status == 'closed':
                 ticket = tag.span(ticket, style="text-decoration: line-through")
-            yield (ctx.resource_href(), ticket + ctx.summary(),
+            yield (ctx.resource_href(),
+                   ticket + ctx.format_summary(summary, status),
                    datetime.fromtimestamp(ts, utc), author,
                    shorten_result(desc, terms))

[Christian Boos]

Well, whatever that error was, it seems to be working now.

[anonymous]

I tested this at SandBox on this server, here is test code.

= header 1 =
this is content1.
== header 2 ==
this is content2.
{{{
#!diff
--- /trunk/trac/htdocs/js/expand_dir.js (revision 5338)
+++ /trunk/trac/htdocs/js/expand_dir.js (revision 5346)
@@ -39,5 +39,5 @@
   // rows to be removed when collapsing that folder
   var folderid = "f" + counter++;
-  td.addClass(folderid);
+  td.addClass(folderid).addClass("expanded");
   var ancestor_folderids = $.grep(tr.attr("class").split(" "), 
 				  function(c) { return c.match(/^f\d+$/)});
}}}

1. View this page in Windows IE6.
2. Select & copy above code, then press Ctrl+C.
3. Click here → [SandBox].
4. Click [Edit this page] button.
5. Select all existing wiki code, then press Ctrl+V.
6. Click [Preview] button. "Header 2" and "this is content2." are hidden by diff table.

[anonymous]

Difference between Windows Firefox 2 and Windows IE 6

[hyuga <hyugaricdeau@…>]

Well, I just tried it myself and was unable to reproduce it anywhere. It's possible that when you tried it in SandBox, some invalid wiki code somewhere (and there is a lot of invalid stuff on that page) might have messed things up. But there doesn't seem to be a problem here.