[PATCH] trac-admin should print error on actions with mistyped username

[vyt@…]

trac-admin permission remove aMonymous WIKI_CREATE

should produce error instead of silent as operation success.

[Christopher Lenz]

How should Trac know that you don't have a user called “aMonymous”. I don't see how we could implement this currently.

[vyt@…]

It can be done by checking known permissions for this actions:

permission add user template_user ("template_user" must exists)[BR] permission remove user permission ("user" must exists)

[sid]

I misunderstood on this on first reading… this is not for an add permission, but for a remove. In this case, Trac does know if the permission exists for a specific user, so it should say "No user with that permission found" or something similar since the remove failed.

[Thijs Triemstra]

against 0.13 trunk r10664

[Thijs Triemstra]

The attached patch prints the following error for unknown users:

$ trac-admin test-trac permission remove anonymous TICKET_VIEWZ
Error: Cannot remove permission TICKET_VIEWZ for username anonymous.

[Christian Boos]

Well, I'm not sure we can do that, as it's a feature to be able to add permissions in advance for yet unknown users. For example, immediately after creating a new environment, you want to be able to add TRAC_ADMIN permission for yourself or some admin account.

[Christian Boos]

Well, for remove it's probably OK, but the summary was more general than that.

[Remy Blank]

I wanted to apply remove-perm-2157.patch​, but _do_remove() has always been so ugly that I took the opportunity to refactor it and add a few unit tests (and fix this issue). The result is in [10685].

As mentioned in comment:8, we don't want an error for permission add.