Edgewall Software

Opened 19 years ago

Closed 18 years ago

Last modified 18 years ago

#2146 closed defect (fixed)

trac-admin fails silently when using all CAPS for a group name

Reported by: trac.20.khaz@… Owned by: Matthew Good
Priority: normal Milestone: 0.10.3
Component: admin/console Version: 0.8.4
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:



On Gentoo with Trac 0.8.4, I'm seeing that if I have a permission table where my user has a role that is all caps (SUPERUSER in my case), it wasn't being used.

That said, if it was 'superuser', it works fine.

I'm fine with that, I just wouldn't mind:

  • People verifying that I'm not on crack and this *is* actually happening for others

( allowing the above is a defect: )

  • Documentation on the permissions page to show what characters are valid/etc
  • Perhaps some error checking or warnings to the user.


Attachments (0)

Change History (6)

comment:1 by Matthew Good, 19 years ago

Component: generaltrac-admin
Owner: changed from Jonas Borgström to Matthew Good
Status: newassigned
Summary: You can't have a role in all capitals.trac-admin should validate permission settings

Yes, you can't use all capitals as a group name, since all caps is reserved for permissions. The WebAdmin plugin does validate the permission values you use, but trac-admin still needs to do this.

A related issue is that WebAdmin also checks the permission values when you delete permissions, which means that if you disable a component that provided certain permissions you can't remove the permission settings since they're not "valid". I can attach a patch here for that since I don't think that we have the authz set up for WebAdmin yet.

comment:2 by anonymous, 18 years ago

We had something similar with version 0.9.4dev; when the group name was "KPIT_developers" the permissions were ignored. Our first guess was that the problem was either the group length or use of underscore in the name. To make it work, we changed the group name to "kpit". May be worth including in the test cases for the fix?

comment:3 by sid, 18 years ago

Summary: trac-admin should validate permission settingstrac-admin fails silently when using all CAPS for a group name

comment:4 by Matthew Good, 18 years ago

Milestone: 0.10.3
Resolution: fixed
Status: assignedclosed

The test when adding a permission was previously fixed in r2358. The problem with removing permissions from disabled components is fixed in r4359 and r4360.

comment:5 by Christian Boos, 18 years ago

#3688 and #4291 were related.

comment:6 by sid, 18 years ago

There is also a note on the TracPermissions page about the requirement that group names must be lowercase. I've added bold so hopefully it is easier to see for people running into the same problem (which I also did at one point).

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Matthew Good.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Matthew Good to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.