Edgewall Software

Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#2121 closed task (wontfix)

Promote r1234 syntax over [1234]

Reported by: Manuzhai Owned by: Christian Boos
Priority: normal Milestone:
Component: general Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


It's more obvious, mostly because it's a more widespread way of point to a SVN changeset. I think Trac should follow this and use this as the default in many places.

Attachments (1)

new-syntax.diff (1.8 KB ) - added by Manuzhai 16 years ago.
Replace [1234] syntax with r1234 syntax in timeline and revlog.

Download all attachments as: .zip

Change History (4)

by Manuzhai, 16 years ago

Attachment: new-syntax.diff added

Replace [1234] syntax with r1234 syntax in timeline and revlog.

comment:1 by Christian Boos, 16 years ago

Owner: changed from Jonas Borgström to Christian Boos
Status: newassigned

I also prefer it that way. Any objections?

comment:2 by Christopher Lenz, 16 years ago

Milestone: 0.91.0

Yes. Please not for 0.9.

I'm not sure how well the r123 syntax would play with other version control systems. I.e. where the changeset idenitifer is not necessarily a number. Would be nice to get some feedback here.

comment:3 by Christian Boos, 16 years ago

Milestone: 1.0
Resolution: wontfix
Status: assignedclosed

You're right, r123 is natural for Subversion, I tend to use that over the [123] notation, but there are other version control systems (e.g. mercurial) for which it doesn't look good in the general case, though it makes sense to use that short notation in places where it's not possible to use the full changeset notation (e.g. as line number column headers, in the diff view).

So let's keep things as they are.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.