Revision call error for a file that no longer exist...

[anonymous]

When i'm looking for a suppressed file, i obtain a view of the last revision which contain this file. That's correct.

BUT. When i fill the revision form whith the next number of revision, instead of a page saying "the file no longer exists", the following page with errors appear.

Oops...
Trac detected an internal error:

("File not found: revision 29, path '/trunk/diffusion_repartie/src/rice/pastry/socket/SocketCollectionManager.java'", 160013)

If you think this really should work and you can reproduce it. Then you should consider to report this problem to the Trac team.

Go to http://trac.edgewall.com/ and create a new ticket where you describe the problem, how to reproduce it. Don't forget to include the python traceback found below.

TracGuide — The Trac User and Administration Guide
Python traceback

Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 531, in cgi_start
    real_cgi_start()
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 526, in real_cgi_start
    dispatch_request(path_info, args, req, env)
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 441, in dispatch_request
    module.run()
  File "/usr/lib/python2.3/site-packages/trac/Module.py", line 44, in run
    self.render()
  File "/usr/lib/python2.3/site-packages/trac/File.py", line 278, in render
    oh = svn.fs.node_history(root, self.path, self.pool)
SubversionException: ("File not found: revision 29, path '/trunk/diffusion_repartie/src/rice/pastry/socket/SocketCollectionManager.java'", 160013)

[Christian Boos]

This works quite fine in the trunk (you'd get an error message).

What I'd like to add, however, is to add a link saying something like "Maybe that path was deleted, <search> for the last revision?".

browser.py

@@ -87 +87 @@
         rev = req.args.get('rev')
 
         repos = self.env.get_repository(req.authname)
-        node = repos.get_node(path, rev)
+        try:
+            node = repos.get_node(path, rev)
+        except TracError, e:
+            ph_href = util.escape(self.env.href.log(path, rev=rev,
+                                                    mode='path_history'))
+            raise TracError(e.message +
+                            '<br><a href="%s">Search</a> for an existing'
+                            ' revision at that path.' % ph_href)
 
         hidden_properties = [p.strip() for p
                              in self.config.get('browser', 'hide_properties',

[Christian Boos]

Btw, the log should behave the same, as reverting to path history mode can be quite time consuming: if I write: log:trunk/ComplexPath and want to check that it's the correct path by doing a preview and testing the link, I don't want to wait 1 minute before Trac tells me that the path doesn't exist.

On the other hand, when dereferencing an old link which used to be valid, having to option to search for the latest existing version of that path is worthwhile.

[Christian Boos]

Patch against r2326 improving the inlined patch and also modifying the revision log behavior so that it doesn't revert by itself to the path history mode when the requested path is not found

[Christian Boos]

I think this patch​ would be a good thing to have for 0.9.

[Christian Boos]

Patch applied in r2354