Cannot change ticket type via WebAdmin plugin

[Shunichi Goto <gotoh@…>]

I found that I cannot rename ticket type value via WebAdmin plugin. The operation causes exception. This problem comes from difference between enum name in enum table and column name in ticket table. So I modified trac.ticket.AbstractEnum and trac.ticket.Type` like this:

model.py

@@ -272 +272 @@
 
 class AbstractEnum(object):
     type = None
+    ticket_column = None
 
     def __init__(self, env, name=None, db=None):
+        if not self.ticket_column:
+            self.ticket_column = self.type
         self.env = env
         if name:
             if not db:
@@ -348 +351 @@
         if self.name != self._old_name:
             # Update tickets
             cursor.execute("UPDATE ticket SET %s=%%s WHERE %s=%%s" %
-                           (self.type, self.type), (self.name, self._old_name))
+                           (self.ticket_column, self.ticket_column),
+                           (self.name, self._old_name))
             self._old_name = self.name
             self._old_value = self.value
 
@@ -371 +375 @@
 
 class Type(AbstractEnum):
     type = 'ticket_type'
+    ticket_column = 'type'
 
 
 class Status(AbstractEnum):

[Shunichi Goto <gotoh@…>]

It seems that this patch was applied in r2344.
(related ticket: #2203)

[Matthew Good]

Well, the tickets are actually duplicates, so only one should be "fixed".

[Matthew Good]

This is a duplicate of #2203.