Traceback in Apache error log

[sam@…]

Sometimes, I get a Python traceback in the Apache's error log because of an unexpected connection close on the client side. I don't think such a big traceback belongs to Apache error log, and this error can be silently ignored.

[Thu Sep 01 02:40:24 2005] [error] [client 84.132.233.102] PythonHandler trac.web.modpython_frontend: Traceback (most recent call last):
[Thu Sep 01 02:40:24 2005] [error] [client 84.132.233.102] PythonHandler trac.web.modpython_frontend:   File "/usr/lib/python2.3/site-packages/mod_python/apache.py", line 299, in HandlerDispatch\n    result = object(req)
[Thu Sep 01 02:40:24 2005] [error] [client 84.132.233.102] PythonHandler trac.web.modpython_frontend:   File "/usr/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 207, in handler\n    send_pretty_error(e, env, mpr)
[Thu Sep 01 02:40:24 2005] [error] [client 84.132.233.102] PythonHandler trac.web.modpython_frontend:   File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 253, in send_pretty_error\n    req.write('Oops...\\n\\nTrac detected an internal error:\\n\\n')
[Thu Sep 01 02:40:24 2005] [error] [client 84.132.233.102] PythonHandler trac.web.modpython_frontend:   File "/usr/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 89, in write\n    self.req.write(data)
[Thu Sep 01 02:40:24 2005] [error] [client 84.132.233.102] PythonHandler trac.web.modpython_frontend: IOError: Write failed, client closed connection.

For information :

[Thu Sep 01 02:38:55 2005] [notice] Apache/2.0.54 (Debian GNU/Linux) DAV/2 SVN/1.2.0 mod_python/3.1.3 Python/2.3.5 PHP/4.4.0-1 mod_ssl/2.0.54 OpenSSL/0.9.7g mod_perl/2.0.1 Perl/v5.8.7 configured -- resuming normal operations

It's been doing this for quite a while now (months).

[Christopher Lenz]

I think the following change would get rid of these errors:

trac/web/main.py

@@ -246 +246 @@
         if env and env.log:
             env.log.error('Failed to render pretty error page: %s', e2,
                           exc_info=True)
-        req.send_response(500)
-        req.send_header('Content-Type', 'text/plain')
-        req.end_headers()
-        req.write('Oops...\n\nTrac detected an internal error:\n\n')
-        req.write(str(e))
-        req.write('\n')
-        req.write(tb.getvalue())
+        try:
+            req.send_response(500)
+            req.send_header('Content-Type', 'text/plain')
+            req.end_headers()
+            req.write('Oops...\n\nTrac detected an internal error:\n\n')
+            req.write(str(e))
+            req.write('\n')
+            req.write(tb.getvalue())
+        except IOError:
+            # Cannot send response, but the error has hopefully been logged
+            pass
 
 def send_project_index(req, options, env_paths=None):
     from trac.web.clearsilver import HDFWrapper

[Christopher Lenz]

Should be fixed in [2267].