Edgewall Software
Modify ↓

Opened 20 years ago

Closed 20 years ago

#1983 closed defect (fixed)

strange rendering when <dd> element contents is empty

Reported by: Shunichi Goto <gotoh@…> Owned by: Christopher Lenz
Priority: low Milestone: 0.9
Component: version control/changeset view Version: devel
Severity: trivial Keywords: layout
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In changeset view, I encounted strange formatting when log message is single LF (1 line, not empty). In this case, the "<DT>Files:</DT>" will be overlayed onto element "<DT>Message:</DT>" It seems to be caused by empty <dd></dd>. I'm using firefox 1.0. I don't know why. But I have workaround by putting &nbsp; changeset.message if empty.

  • templates/changeset.cs

     
    106106 <dt class="author">Author:</dt>
    107107 <dd class="author"><?cs var:changeset.author ?></dd>
    108108 <dt class="message">Message:</dt>
    109  <dd class="message" id="searchable"><?cs var:changeset.message ?></dd>
     109 <dd class="message" id="searchable"><?cs
     110  alt:changeset.message ?>&nbsp;<?cs /alt ?></dd>
    110111 <dt class="files">Files:</dt>
    111112 <dd class="files">
    112113  <ul><?cs each:item = changeset.changes ?>

Attachments (0)

Change History (2)

comment:1 by Christopher Lenz, 20 years ago

Milestone: → 0.9
Owner: changed from Jonas Borgström to Christopher Lenz
Severity: minor → trivial
Status: new → assigned

Will look into this.

comment:2 by Christopher Lenz, 20 years ago

Resolution: → fixed
Status: assigned → closed

Patch applied in [2407]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.