Edgewall Software
Modify ↓

Opened 19 years ago

Closed 19 years ago

#1884 closed defect (fixed)

[patch] Notify has a subtle bug when users don't enter an email in settings.

Reported by: anthony.vito@… Owned by: Jonas Borgström
Priority: normal Milestone: 0.9
Component: ticket system Version: devel
Severity: normal Keywords: notify
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

My usage of notify involved setting up an "always_cc" list of a few developers. Everyone has a user name in trac, but no one has entered an email address in settings. When someone added a user name to the cc field in a ticket. The email notification crashed with this error. (minus the trace) 

Trac[web_ui]
ERROR: Failure sending notification on change to ticket #899:
TypeError: iteration over non-sequence

I tracked the error down to a single line in the Notify.py file. The loop that converts user names into real email address isn't checking to make sure it's getting anything back. So in my case, it wasn't, and it caused the error.

Attachments (1)

Notify_check_for_email.patch​ (688 bytes ) - added by anthony.vito@… 19 years ago.
The patch to Notify.py that fixes the issue.

Download all attachments as: .zip

Change History (2)

by anthony.vito@…, 19 years ago

Attachment: Notify_check_for_email.patch​ added

The patch to Notify.py that fixes the issue.

comment:1 by Christopher Lenz, 19 years ago

Resolution: → fixed
Status: new → closed

Checked in a modified version of the patch in [2064]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.