RTF displayed as plain text

[anonymous]

Is it possible to render rich text format in trac? In r2040 .rtf attachments show up as plain text (quite impossible to read), is it atleast possible to tell the browser to download .rtf directly?

[Christopher Lenz]

Better summary

[Christian Boos]

The is_binary heuristic will "fail" for RTF (and PDF, and PostScript…)

I would propose the following fix (would also fix #1920, I believe)

trac/mimeview/api.py

@@ -79 +79 @@
     'rb':'text/x-ruby', 'ruby':'text/x-ruby',
     'rfc':'text/x-rfc',
     'rst': 'text/x-rst',
+    'rtf':'application/rtf',
     'scm':'text/x-scheme',
     'sh':'application/x-sh',
     'sql':'text/x-sql',
@@ -328 +329 @@
         return 1
 
     def render(self, req, mimetype, content, filename=None, rev=None):
-        if is_binary(content):
+        if is_binary(content) \
+           or (mimetype.startswith('application/')
+               and mimetype[12:] in ('pdf', 'postscript', 'rtf')):
             self.env.log.debug("Binary data; no preview available")
             return

[Christian Boos]

PS: adding the above test in render and not in is_binary makes it possible to force the display of the actual text content in the browser by clicking on the Plain Text link.

[Christian Boos]

Should by fixed by r2108.