Edgewall Software
Modify

Opened 19 years ago

Closed 15 years ago

Last modified 12 years ago

#1844 closed defect (wontfix)

trac-post-commit should go fine with svn merges

Reported by: Christian Parpart <trapni@…> Owned by: Christian Boos
Priority: normal Milestone:
Component: version control Version: devel
Severity: minor Keywords: post-commit-hook svk helpwanted
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Hi,

as I got *NO* response in the list, I'm trying it here.

trac-post-commit interprets fragments like "closes #7", "refs #8" and alike.

When a merge happens (using svk) e.g. using the following command: svk smerge -l /bugfix-branch /stable-branch where -l specifies to use the prio commit log messages as merge commit log messages;

this implies that the above mentioned "refs #8" (and alike) will be interpreted again.

is there a way to fix this in trac-post-commit?

Attachments (0)

Change History (6)

comment:1 by Christian Boos, 19 years ago

In the scenario you described, I think it makes sense for the commit message to be interpreted again, as this helps you to keep track in which branches the fixes have been incorporated.

comment:2 by Christopher Lenz, 19 years ago

Milestone: 0.9

Later (if this is even an issue)

comment:3 by Christian Boos, 18 years ago

Component: generalversion control
Keywords: post-commit-hook svk helpwanted added
Milestone: none
Owner: changed from Jonas Borgström to Christian Boos

I don't have svk installed at hand, but I think that if you don't also specify --verbatim, you'll get a header for the smerge commit log. In the post-commit hook, that could be used to special case this situation.

comment:4 by Jason Winnebeck <jpwasp@…>, 16 years ago

Yeah, in my environment I specifically do want the "refs" to process again (although I'm doing merging through another took than svk). However, the problem is with the "closes" command — if a ticket is reopened you might not want to close it when copying an old command.

I don't think this is a problem that Trac could solve, though, since it doesn't know the source of any particular commit. trac-post-commit-hook can't solve every situation, or you could modify it to handle the svk cases.

comment:5 by anatoly techtonik <techtonik@…>, 15 years ago

Resolution: wontfix
Status: newclosed

This ticket seems to be too old. SVK is no longer actively maintained, so I close this as "won't fix". It could be opened if the issue actual with SVN, but seems like its not, so making trac-post-commit-hook understand SVK merge information is a task for SVK community, not Trac.

comment:6 by Christian Boos, 12 years ago

Milestone: not applicable

(clearing report:35)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.