Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#1762 closed defect (fixed)

Windows line endings break PHP highlighting

Reported by: Markus Tacker <m@…> Owned by: Matthew Good
Priority: normal Milestone: 0.9
Component: version control/browser Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

This is the trac view for this file.

Only the first line is displayed in the trac view.

Attachments (0)

Change History (6)

comment:1 by Matthew Good, 17 years ago

Owner: changed from Jonas Borgström to Matthew Good
Status: newassigned

Well, this seems to be a case of the PHP highlighter behaving stupidly. If the file contains Windows CRLF line endings it removes the CR (replacing it with a <br /> for the HTML), but it leaves all the LF characters. I'll provide a workaround, but it seems like PHP should either leave the line endings wholly intact, or remove them completely.

comment:2 by Christian Boos, 17 years ago

Owner: changed from Matthew Good to Christian Boos

I'll try to reproduce the problem… You are using PHP for syntax highlighting, but which PHP version is it?

comment:3 by Christian Boos, 17 years ago

Owner: changed from Christian Boos to Matthew Good
Status: assignednew

oops, sorry, concurrent edit :)

comment:4 by Matthew Good, 17 years ago

Milestone: 0.9
Resolution: fixed
Status: newclosed
Summary: PHP in source view doesn't display correctlyWIndows line endings break PHP highlighting

This has been fixed in [1918]

comment:5 by trac@…, 17 years ago

Summary: WIndows line endings break PHP highlightingWindows line endings break PHP highlighting

comment:6 by Markus Tacker <m@…>, 17 years ago

The PHP version is # php -v PHP 5.1.0b2 (cli) (built: Jul 7 2005 23:18:22) Copyright © 1997-2005 The PHP Group Zend Engine v2.1.0b2, Copyright © 1998-2004 Zend Technologies

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Matthew Good.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Matthew Good to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.