Edgewall Software
Modify

Opened 19 years ago

Closed 19 years ago

Last modified 12 years ago

#1734 closed defect (worksforme)

Ticket URL not showing in notification emails

Reported by: anonymous Owned by: Jonas Borgström
Priority: normal Milestone:
Component: ticket system Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

After adding or modifying a ticket the Ticket URL is not showing in the email sent.

[snip]

  • status: new ⇒ closed
  • resolution: ⇒ fixed

— Ticket URL: ≠

snip

RSS feed shows the url properly though.

Attachments (1)

Notify.patch (525 bytes ) - added by linne@… 19 years ago.
Working patch for #1734

Download all attachments as: .zip

Change History (12)

comment:1 by anonymous, 19 years ago

Priority: normalhighest
Severity: normalcritical

comment:2 by Matthew Good, 19 years ago

Priority: highestnormal
Severity: criticalnormal

This is not a "critical" issue since that would mean that there was data loss or some other serious problem that made the system unusable.

comment:3 by anonymous, 19 years ago

You can fix this by adding:

        self.hdf['ticket.link'] = self.env.abs_href.ticket(ticket.id)

To line 183 of Notify.py. changeset:1832 removed the link property which the email template was depending on, i think. See #1743 for formatting fixes as well.

comment:4 by evan.s@…, 19 years ago

I still get no Ticket URL with

self.hdf['ticket.link'] = self.env.abs_href.ticket(ticket.id)

added to Notify.py

comment:5 by evan.s@…, 19 years ago

Actually, it does work — had to wait for Python to catch up and begin using the modified Notify.py I suppose. Thanks for the fix :)

by linne@…, 19 years ago

Attachment: Notify.patch added

Working patch for #1734

comment:6 by anonymous, 19 years ago

Milestone: 0.9

comment:7 by Christopher Lenz, 19 years ago

Resolution: fixed
Status: newclosed

Fixed in [2062].

comment:8 by tiger@…, 19 years ago

Resolution: fixed
Status: closedreopened

Still missing in the trunk. Please apply the patch below:

Index: trac/Notify.py
===================================================================
--- trac/Notify.py      (revision 2067)
+++ trac/Notify.py      (working copy)
@@ -181,6 +181,7 @@
         self.hdf['email.ticket_body_hdr'] = self.format_hdr()
         self.hdf['ticket'] = self.ticket.values
         self.hdf['ticket.new'] = self.newticket
+        self.hdf['ticket.link'] = self.env.abs_href.ticket(ticket.id)
         subject = self.format_subj()
         if not self.newticket:
             subject = 'Re: ' + subject

comment:9 by anonymous, 19 years ago

I am currently using the trunk and my notification emails look fine. They contain the correct ticket URL. The edgewall site is running the latest trunk and the ticket archives also show that the emails look fine.

comment:10 by Matthew Good, 19 years ago

Resolution: worksforme
Status: reopenedclosed

The value ticket.link is read from the ticket properties, so it should not need to be set directly. As the person above said, the notifications on the Trac project seem to have the link, and I can verify that this is working on my trunk installation as well, so the above patch is not necessary.

comment:11 by Christian Boos, 12 years ago

Milestone: 0.9

(clearing report:35)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.