#1734 closed defect (worksforme)
Ticket URL not showing in notification emails
Reported by: | anonymous | Owned by: | Jonas Borgström |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | ticket system | Version: | devel |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
After adding or modifying a ticket the Ticket URL is not showing in the email sent.
[snip]
- status: new ⇒ closed
- resolution: ⇒ fixed
— Ticket URL: ≠
RSS feed shows the url properly though.
Attachments (1)
Change History (12)
comment:1 by , 19 years ago
Priority: | normal → highest |
---|---|
Severity: | normal → critical |
comment:2 by , 19 years ago
Priority: | highest → normal |
---|---|
Severity: | critical → normal |
comment:3 by , 19 years ago
You can fix this by adding:
self.hdf['ticket.link'] = self.env.abs_href.ticket(ticket.id)
To line 183 of Notify.py. changeset:1832 removed the link property which the email template was depending on, i think. See #1743 for formatting fixes as well.
comment:4 by , 19 years ago
I still get no Ticket URL with
self.hdf['ticket.link'] = self.env.abs_href.ticket(ticket.id)
added to Notify.py
comment:5 by , 19 years ago
Actually, it does work — had to wait for Python to catch up and begin using the modified Notify.py I suppose. Thanks for the fix :)
comment:6 by , 19 years ago
Milestone: | → 0.9 |
---|
comment:8 by , 19 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Still missing in the trunk. Please apply the patch below:
Index: trac/Notify.py =================================================================== --- trac/Notify.py (revision 2067) +++ trac/Notify.py (working copy) @@ -181,6 +181,7 @@ self.hdf['email.ticket_body_hdr'] = self.format_hdr() self.hdf['ticket'] = self.ticket.values self.hdf['ticket.new'] = self.newticket + self.hdf['ticket.link'] = self.env.abs_href.ticket(ticket.id) subject = self.format_subj() if not self.newticket: subject = 'Re: ' + subject
comment:9 by , 19 years ago
I am currently using the trunk and my notification emails look fine. They contain the correct ticket URL. The edgewall site is running the latest trunk and the ticket archives also show that the emails look fine.
comment:10 by , 19 years ago
Resolution: | → worksforme |
---|---|
Status: | reopened → closed |
The value ticket.link
is read from the ticket properties, so it should not need to be set directly. As the person above said, the notifications on the Trac project seem to have the link, and I can verify that this is working on my trunk installation as well, so the above patch is not necessary.
This is not a "critical" issue since that would mean that there was data loss or some other serious problem that made the system unusable.