Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#1659 closed defect (fixed)

Alternate formats for reports are broken

Reported by: Emmanuel Blot Owned by: Christian Boos
Priority: normal Milestone: 0.9
Component: report system Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

In [1762]

When RSS format is chosen, the HTML regular format is generated When CSV, TSV or SQL format is chosen, the appropriate format is generated, it is nevertheless followed by the full HTML content (including HTTP headers)

Attachments (1)

report.cs.patch (681 bytes ) - added by Emmanuel Blot 14 years ago.
Patch sample for [1762]

Download all attachments as: .zip

Change History (4)

by Emmanuel Blot, 14 years ago

Attachment: report.cs.patch added

Patch sample for [1762]

comment:1 by Emmanuel Blot, 14 years ago

The trouble seems to come from the way ReportModule._render_view(req, db, id) is handled in process_request.

The return value is not tested, and the execution of process_request resumes, whereas it should only resume if no alternate format is used.

The attached patch is probably not the best way to solve the issue - I'm not a good Python developer.

comment:2 by Christian Boos, 14 years ago

Owner: changed from Christopher Lenz to Christian Boos
Status: newassigned

… - I'm not a good Python developer.

Trac is an excellent reason for learning python :)

comment:3 by Christian Boos, 14 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [1778]

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.