Edgewall Software

Opened 16 years ago

Closed 11 years ago

#1538 closed defect (worksforme)

Email notify fail if user have blank email field in settings

Reported by: vyt@… Owned by: Matthew Good
Priority: normal Milestone:
Component: notification Version: devel
Severity: major Keywords: verify bitesized
Cc: brianlsmith@…, vyt@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

I use trac trunk from 22 april 2005 with settings

always_notify_reporter = true always_notify_owner = true

If reporter not specified email address in settings, then trac fails to send emails:

Trac[Ticket] ERROR: Failure sending notification on change to ticket #25: iteration over non-sequence Traceback (most recent call last): 
  File "/usr/lib/python2.4/site-packages/trac/Ticket.py", line 434, in save_changes     tn.notify(ticket, newticket=0, modtime=now)
  File "/usr/lib/python2.4/site-packages/trac/Notify.py", line 217, in notify     NotifyEmail.notify(self, ticket['id'], subject
  File "/usr/lib/python2.4/site-packages/trac/Notify.py", line 117, in notify     Notify.notify(self, resid) 
  File "/usr/lib/python2.4/site-packages/trac/Notify.py", line 56, in notify     self.send(to) 
  File "/usr/lib/python2.4/site-packages/trac/Notify.py", line 356, in send     NotifyEmail.send(self, rcpt, hdrs)   File "/usr/lib/python2.4/site-packages/trac/Notify.py", line 150, in send     self.server.sendmail(self.from_email, rcpt, msg.as_string()) 
  File "/usr/lib/python2.4/smtplib.py", line 681, in sendmail     for each in to_addrs: TypeError: iteration over non-sequence

Attachments (0)

Change History (14)

comment:1 by PBruin, 16 years ago

Cc: peter.bruin@… added

I have a similar experience. This time I added a new email to the cc. I kept on getting the error until I removed the person from the cc again. However, the email was successfully send to all people on the cc list and the item was added three times to the ticket.
I am using r1724.

Traceback (most recent call last):
  File "c:\python23\Lib\site-packages\trac\web\modpython_frontend.py", line 265, in handler
    dispatch_request(mpr.path_info, mpr, env)
  File "c:\python23\Lib\site-packages\trac\web\main.py", line 419, in dispatch_request
  File "c:\python23\Lib\site-packages\trac\web\main.py", line 283, in dispatch
    resp = chosen_handler.process_request(req)
  File "c:\python23\Lib\site-packages\trac\Ticket.py", line 435, in process_request
    self._do_save(req, db, ticket)
  File "c:\python23\Lib\site-packages\trac\Ticket.py", line 576, in _do_save
    self.log.exception("Failure sending notification on change to "
TypeError: int argument required

comment:2 by PBruin, 16 years ago

Maybe one more hint on the above.
I added the comment plus I added a person to the CC list. All persons where userid except for the new cc, this was an email address.

comment:3 by Matthew Good, 16 years ago

Owner: changed from Jonas Borgström to Matthew Good
Status: newassigned

I'll take a look at this with some of the other work I'm doing on the notification.

comment:4 by vyt@…, 15 years ago

What progress about it ?

comment:5 by anonymous, 15 years ago

Cc: brianlsmith@… added

comment:6 by Emmanuel Blot, 14 years ago

I think this issue has been fixed in 0.10

comment:7 by anonymous, 14 years ago

Cc: peter.bruin@… removed

comment:8 by anonymous, 14 years ago

#2729 has been marked as a duplicate. It also contains a simple patch (not sure for what version or rev though).

comment:9 by sid, 14 years ago

Keywords: needinfo added

Does this work in 0.10 now? Need to test.

comment:10 by Christian Boos, 14 years ago

Component: ticket systemnotification
Milestone: 0.10.5

Should be verified.

comment:11 by Christian Boos, 13 years ago

Description: modified (diff)
Keywords: verify added; needinfo removed

It's probably working now, but worth doing a check.

comment:12 by Remy Blank, 11 years ago

Keywords: bitesized added

comment:13 by Guy Rozendorn, 11 years ago

I've verified that:

  1. if both always_notify_reporter and always_notify_owner are set to True, and there's no owner defined, the mail is sent successfully to the porter, no errors there.
  2. added to the cc field both a username and an e-mail address. e-mail were sent successfully to all recipients.

ticket verified.

comment:14 by Remy Blank, 11 years ago

Milestone: next-minor-0.12.x
Resolution: worksforme
Status: assignedclosed

Excellent, thanks.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Matthew Good.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Matthew Good to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.