Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#1444 closed enhancement (fixed)

Enhanced diff viewer

Reported by: ludde Owned by: Christopher Lenz
Priority: normal Milestone: 0.9
Component: general Version: 0.8.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Add an option to display .diff-files in the same way that diffs in a changeset are shown.

Attachments (0)

Change History (6)

comment:1 by xris@…, 17 years ago

Severity: normalenhancement

I second this idea. trac's changeset viewer is much easier to read than a diff file.

comment:3 by Christian Boos, 17 years ago

I tested the patch a little bit, it works well for .diff files, but it exits too early when processing inline diff blocks in the Wiki: it exits after scanning a few lines, e.g. if I output the lines that are scanned, I get:

1 Index: trac/versioncontrol/svn_fs.py
2 ===================================================================
3 --- trac/versioncontrol/svn_fs.py       (revision 1535)
4 +++ trac/versioncontrol/svn_fs.py       (working copy)
5 @@ -55,49 +55,44 @@
6

6 is an empty line, and then it stops…

comment:4 by Christopher Lenz, 17 years ago

Milestone: 0.9
Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned

Line 6 should containing a leading space, i.e. it should not be empty for a proper diff.

comment:5 by Christopher Lenz, 17 years ago

Resolution: fixed
Status: assignedclosed

Implemented in [1622]. Thanks for the patch!

comment:6 by Christian Boos, 17 years ago

I nevertheless think it's worth supporting the patches containing empty lines, since it's pretty common to insert small diffs in wiki pages that you just generated with a command line utility (e.g. copy/pasting the output of svn diff).

In a Windows console (cmd.exe or even Putty), that leading space is lost.

I checked xterm on Linux and it works properly (i.e. the leading space is preserved), but Konsole (1.2.3, KDE 3.1.4) also fails to preserve that leading space.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.