Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#1426 closed enhancement (fixed)

Display file size while browse source

Reported by: yxsap@… Owned by: Christian Boos
Priority: normal Milestone: 0.9
Component: general Version: none
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description


Attachments (1)

file_size_in_browser.patch (2.9 KB ) - added by Christian Boos 17 years ago.
Proposed implementation of the feature

Download all attachments as: .zip

Change History (4)

by Christian Boos, 17 years ago

Attachment: file_size_in_browser.patch added

Proposed implementation of the feature

comment:1 by Christian Boos, 17 years ago

Owner: changed from Jonas Borgström to Christian Boos
Status: newassigned

Should I commit it?

comment:2 by Matthew Good, 17 years ago

I haven't tested it yet, but it looks ok to me. One thing to change is pretty_size should cast the size to a float if it's too big to display in bytes, since int division will accumulate errors. You could also display a decimal place or two.

I'm undecided about this, but it would also be possible to set the size jumps at 512 instead of 1024 (e.g. display 0.5MB instead of 512kB).

comment:3 by Christian Boos, 17 years ago

Resolution: fixed
Status: assignedclosed

I implemented the patch, along with your suggestions in [1507]. I also made the column sortable.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.