[timeline] max_daysback option set to `-1` doesn't work

[Jun Omae]

Originally reported at ​gmessage:trac-users:IC701Q0mnz0/m/oAbQHgP_CwA.

According to document of [timeline] max_daysback option, setting -1 to the option allows unlimited for daysback input. However, actually not work.

[Jun Omae]

Proposed changes:

trac/timeline/tests/web_ui.py

@@ -180 +180 @@
 
         self.assertEqual(90, data['daysback'])
 
+    def test_max_daysback_unlimited(self):
+        """Daysback is unlimited if [timeline] max_daysback set to -1."""
+        self.env.config.set('timeline', 'max_daysback', '-1')
+        req = MockRequest(self.env, args={'daysback': '365'})
+        data = TimelineModule(self.env).process_request(req)[1]
+        self.assertEqual(365, data['daysback'])
+
     def test_daysback_invalid_default_is_used(self):
         """Daysback request value is invalid: default value is used."""
         req = MockRequest(self.env, args={'daysback': '--'})

trac/timeline/web_ui.py

@@ -135 +135 @@
 
         pref = req.session.as_int('timeline.daysback', self.default_daysback)
         default = 90 if format == 'rss' else pref
-        daysback = req.args.as_int('daysback', default,
-                                   min=0, max=self.max_daysback)
+        max_daysback = self.max_daysback
+        daysback = req.args.as_int('daysback', default, min=0,
+                                   max=max_daysback if max_daysback >= 0 else
+                                       None)
 
         authors = req.args.get('authors')
         if authors is None and format != 'rss':