Edgewall Software
Modify ↓

Opened 9 months ago

Closed 9 months ago

#13867 closed defect (fixed)

Unit tests failing with Subversion 1.14.5

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.6.1
Component: version control Version: 1.6
Severity: normal Keywords: svn
Cc: Branch:
Release Notes:

Fixed AttributeError raised from SubversionNode.get_copy_ancestry with Subversion 1.14.5.

API Changes:
Internal Changes:

Description

It seems that SubversionNode.get_copy_ancestry raises the following AttributeError in the all failures. 

======================================================================
ERROR: test_get_copy_ancestry_for_move (tracopt.versioncontrol.svn.tests.svn_fs.SvnCachedRepositoryScopedTests.test_get_copy_ancestry_for_move)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/trac/trac/tracopt/versioncontrol/svn/tests/svn_fs.py", line 1267, in test_get_copy_ancestry_for_move
    ancestry = node.get_copy_ancestry()
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/trac/trac/tracopt/versioncontrol/svn/svn_fs.py", line 855, in get_copy_ancestry
    path = path.lstrip(b'/')
           ^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'lstrip'

...
Ran 2810 tests in 554.016s

FAILED (errors=12, skipped=5)

Attachments (0)

Change History (2)

comment:1 by Jun Omae, 9 months ago

Keywords: macos removed
Summary: Unit tests of Subversion is failing on macOS → Unit tests failing with Subversion 1.14.5

Hmm, the same failures occur with Subversion 1.14.5 on both Ubuntu and macOS. They doesn't occur with Subversion 1.14.4.

comment:2 by Jun Omae, 9 months ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

After Subversion 1.14.5, svn.fs.closest_copy returns (None, None) instead of None when no given copy exists.

Fixed in [17883] and merged in [17884].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.