Improve diff display

[Dirk Stöcker]

The diff functionality in trac has a very simple method to show changes in a line. In JOSM wiki we use this diff a lot for translation and I wanted a better display. The attached patch​ improves trac/versioncontrol/diff.py to highlight differences more specifically.

Example

old:

new:

[Dirk Stöcker]

The diff as file

[Dirk Stöcker]

old state

[Dirk Stöcker]

new state

[Jun Omae]

That is the same of (or probably related) #6858. I'll try the patch.

[Dirk Stöcker]

I found one other usage of the function get_change_extent (without "s") in (mimeview/patch.py) which needs to be adapted as the one in diff.py. Code can be copied 1:1 it seems.

Yes. This seems identical to #6858, only for current codebase.

[Dirk Stöcker]

NOTE: Reverse sort is necessary, so the inserts of \0 and \1 are at correct positions.

[Dirk Stöcker]

Added missing changes (tests, docs)

[Dirk Stöcker]

I extended to patch to cover all necessary changes

[Dirk Stöcker]

Using this 4 months now in JOSM trac. No negative effects.

[Dirk Stöcker]

Beep

[Philippe Cloutier <chealer@…>]

Thank you very much Dirk, that looks like quite an improvement (judging from the provided example alone). I wish all of this could be handled by a library, but I'm glad your version seems to offload more of the work.👏

Is this about the source code browser only, or also improving the wiki and other components?

If I may:

1. The variable names (new, n, e) could be more descriptive.
2. "typles" should read "tuples".

This comment is from Philippe "Chealer" Cloutier. All of my comments and contributions in this ticket are offered under the terms of CC0 1.0 (unless otherwise noted).

[Jun Omae]

I think we should keep the naming of the get_change_extent method because it is listed in __all__ and public.