Focused item of autocomplete menu in diff view should have background color

[Jun Omae]

Focused item of autocomplete menu in diff view has no background color.

In the above screenshot, first item is wrongly //, should be /.

[Jun Omae]

If overwriting _renderItem for autocomplete, div element should be appended to the li element.

trac/versioncontrol/templates/diff_form.html

@@ -23 +23 @@
     ${ super() }
     <script>
       jQuery(function($) {
-        $("#anydiff input[name$='_path']").autocomplete({
-          source: window.location.pathname
-        }).each(function() {
-          $(this).data("ui-autocomplete")._renderItem = function(ul, item) {
-            return $("<li>")
-              .data("ui-autocomplete-item", item.value)
-              .addClass(function() {
-                return item.isdir ? "trac-autocomplete-dir"
-                                  : "trac-autocomplete-file";
-              })
-              .append(item.label)
-              .appendTo(ul);
-          }
-        })
+        var _renderItem = function(ul, item) {
+          return $("<li>")
+            .addClass(item.isdir ? "trac-autocomplete-dir"
+                                 : "trac-autocomplete-file")
+            .append($("<div>").append(item.label))  // ui-menu-item-wrapper
+            .appendTo(ul);
+        };
+        $("#anydiff input[name$='_path']")
+          .autocomplete({source: window.location.pathname})
+          .each(function() {
+            $(this).autocomplete("instance")._renderItem = _renderItem;
+          });
       });
     </script>
     # endblock head

[Jun Omae]

Fixed in [17864:17865] and merged in [17866].