Edgewall Software
Modify

Opened 2 months ago

Closed 2 months ago

#13787 closed defect (fixed)

test_pytz_choibalsan failing with pytz 2024.2 (tzdata 2024b)

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.6.1
Component: general Version:
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Removed tests with Asia/Choibalsan for datefmt.

Description

See https://github.com/edgewall/trac/actions/runs/11005628298/job/30558646895#step:7:551

======================================================================
FAIL: test_pytz_choibalsan (trac.util.tests.datefmt.LocalTimezoneTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jun66j5/src/tracdev/git/trac/util/tests/datefmt.py", line 2024, in test_pytz_choibalsan
    self._compare_pytz(tz, '1983-04-01T00:00')  # +2:00 (TZ change)
  File "/home/jun66j5/src/tracdev/git/trac/util/tests/datefmt.py", line 2010, in _compare_pytz
    self._compare_pytz_arithmetic(tz, dt_naive)
  File "/home/jun66j5/src/tracdev/git/trac/util/tests/datefmt.py", line 1974, in _compare_pytz_arithmetic
    self.assertEqual(dt_tz.isoformat(), dt_localtz.isoformat())
AssertionError: '1983-04-01T01:00:00+09:00' != '1983-04-01T02:00:00+10:00'
- 1983-04-01T01:00:00+09:00
?             ^        -
+ 1983-04-01T02:00:00+10:00
?             ^       +

Attachments (0)

Change History (2)

comment:1 by Jun Omae, 2 months ago

According to 2024b release of tz code and data available - tz-announce - lists.iana.org:

   Changes to past timestamps

     Asia/Choibalsan is now an alias for Asia/Ulaanbaatar rather than
     being a separate Zone with differing behavior before April 2008.
     This seems better given our wildly conflicting information about
     Mongolia's time zone history.

So I'll remove datefmt tests with Asia/Choibalsan between pytz and libc.

Last edited 2 months ago by Jun Omae (previous) (diff)

comment:2 by Jun Omae, 2 months ago

Internal Changes: modified (diff)
Resolution: fixed
Status: assignedclosed

Removed test_pytz_choibalsan in [17841] and merged in [17842].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.