Modify ↓
      
Opened 14 months ago
Closed 12 months ago
#13784 closed defect (fixed)
wikiColumn in wiki.js makes forcibly the background of elements white
| Reported by: | Jun Omae | Owned by: | Jun Omae | 
|---|---|---|---|
| Priority: | normal | Milestone: | 1.6.1 | 
| Component: | wiki system | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | 
           
Fixed the auto-centering of  
  | 
      ||
| API Changes: | |||
| Internal Changes: | |||
Description
The div.wiki-toc that generated by PageOutline macro has #ffd (yellow) as background color. However, wikiColumn in wiki.js resets it to white with alpha 0.8 rgb(255, 255, 255, 0.8) or background: none.
I don't think it should reset the background color, instead, it should apply opacity: 0.8 and remove the applied styles.
- 
      
trac/htdocs/js/wiki.js
diff --git a/trac/htdocs/js/wiki.js b/trac/htdocs/js/wiki.js index d89ea9531..167b65819 100644
a b 39 39 if (shift_left > wpleft) 40 40 shift_left = wpleft; 41 41 42 $e.css({'margin-left': -shift_left, 43 'background': 'rgba(255, 255, 255, .8)'}); 42 $e.css({'margin-left': -shift_left, 'opacity': '.8'}); 44 43 }; 45 44 var resetLargeElements = function() { 46 for (var i = 0; i < large_elements.length; i++) { 47 $(large_elements[i]).css({'margin-left': 0, 'background': 'none'}); 48 } 45 $(large_elements).css({'margin-left': '', 'opacity': ''}); 49 46 }; 50 47 var detectLargeImage = function() { 51 48 var excess = detectLargeElement.apply(this);  
Attachments (0)
Change History (2)
comment:1 by , 14 months ago
comment:2 by , 12 months ago
| Release Notes: | modified (diff) | 
|---|---|
| Resolution: | → fixed | 
| Status: | assigned → closed | 
I fixed some issues in [17867] and merged in [17868]. See release notes field.
  Note:
 See   TracTickets
 for help on using tickets.
    


  
Also, elements which its
floatis notnonelike such.wiki-tocshould be ignored.trac/htdocs/js/wiki.js
(this).data('excess', excess);(this).data('rol', rol);