RegistrationFilterStrategy raises AttributeError: 'Fragment' object has no attribute 'replace'

[Jun Omae]

Originally reported at ​gmessage:trac-users:OKhqlyY5s0w/m/GJl9B2nlAAAJ.

Trac[filtersystem] ERROR: Filter strategy <Component tracspamfilter.filters.registration.RegistrationFilterStrategy> raised exception: 'Fragment' object has no attribute 'replace'
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/tracspamfilter/filters/registration.py", line 81, in test
    check.validate_registration(req)
  File "/usr/local/lib/python3.10/dist-packages/acct_mgr/register.py", line 289, in validate_registration
    raise RegistrationError(tag_(
acct_mgr.register.RegistrationError: Username <b>test</b> doesn't match local naming policy.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/tracspamfilter/filtersystem.py", line 200, in test
    retval = strategy.test(req, author, content, ip)
  File "/usr/local/lib/python3.10/dist-packages/tracspamfilter/filters/registration.py", line 84, in test
    msg = e.message.replace('\n', '')
AttributeError: 'Fragment' object has no attribute 'replace'

I think we could use to_unicode and striptags to extract the message from the RegistrationError exception.

tracspamfilter/filters/registration.py

@@ -16 +16 @@
 
 from trac.config import BoolOption, IntOption
 from trac.core import Component, ExtensionPoint, implements
-from trac.util.html import tag
+from trac.util.html import striptags, tag
+from trac.util.text import to_unicode
 
 from tracspamfilter.api import IFilterStrategy, N_
 
@@ -81 +82 @@
                         check.validate_registration(req)
                 except RegistrationError as e:
                     karma -= abs(self.karma_points)
-                    msg = e.message.replace('\n', '')
-                    args = e.msg_args
-                    if args:
-                        msg = msg % args
-                        msg.replace('<b>', '*').replace('</b>', '*')
+                    msg = striptags(to_unicode(e))
                     self.log.debug("Registration check returned %s", msg)
                     checks.append('%s: %s' % (check.__class__.__name__, msg))
                 except Exception as e:

[Dirk Stöcker]

Did you check your patch beside "compiles"? As far as I can see it will loose argument expansion and also conversion to bold for <b>. I think it's only necessary to convert e.message to unicode.

tracspamfilter/filters/registration.py

@@ -81 +81 @@
                         check.validate_registration(req)
                 except RegistrationError as e:
                     karma -= abs(self.karma_points)
-                    msg = e.message.replace('\n', '')
+                    msg = unicode(e.message).replace('\n', '')
                     args = e.msg_args
                     if args:
                         msg = msg % args

[Jun Omae]

At least, the conversion to bold for <b>/</b> doesn't work. Also, msg % args is not needed because accountmanagerplugin currently creates the exception with formatted message at all places.

-                        msg = msg % args
-                        msg.replace('<b>', '*').replace('</b>', '*')
+                        msg = msg.replace('<b>', '*').replace('</b>', '*')

[Dirk Stöcker]

In r17824.

I used mainly your original patch. Seems accountmanager changed a bit after I first implemented this.