Opened 8 months ago
Closed 8 months ago
#13744 closed enhancement (fixed)
[PATCH] SpamFilter: Support pillow 10 for ImageCaptcha
| Reported by: | Owned by: | Dirk Stöcker | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | plugin/spamfilter | Version: | 1.6 |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Currently the ImageCaptcha component is not compatible with a modern pillow, due to API changes. This patch makes it compatible with Pillow 10 (tested with 10.2.0) and bumps the minimum required version.
Attachments (2)
Change History (6)
by , 8 months ago
| Attachment: | pillow-update.patch added |
|---|
comment:1 by , 8 months ago
follow-up: 3 comment:2 by , 8 months ago
Be careful using _ as an unused variable placeholder because Trac uses it as an alias for a message translation function.
comment:3 by , 8 months ago
Replying to Dirk Stöcker:
Requiring pillow 10 ATM is too much. Ubuntu 22.04 e.g. delivers 9.0.1. openSUSE 15.5 delivers 8.4.0.
Please adapt the patch so that it can handle older versions as well. Requiring PIL ≥ 8 would be ok I think. A simple if/try around the one command should do the trick.
I tested the changes with 8.0.0 and it still works, so I updated the patch to require version 8 or higher.
Replying to Ryan J Ollos:
Be careful using
_as an unused variable placeholder because Trac uses it as an alias for a message translation function.
Thanks for that note. I have used regular variable names in the updated patch.
by , 8 months ago
| Attachment: | pillow-update-v2.patch added |
|---|
Updated pillow requirements and names of variables.
Requiring pillow 10 ATM is too much. Ubuntu 22.04 e.g. delivers 9.0.1. openSUSE 15.5 delivers 8.4.0.
Please adapt the patch so that it can handle older versions as well. Requiring PIL ≥ 8 would be ok I think. A simple if/try around the one command should do the trick.