Edgewall Software
Modify

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#13585 closed enhancement (wontfix)

Log view URL parameter to mark / highlight changesets

Reported by: anonymous Owned by:
Priority: normal Milestone:
Component: version control/log view Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

We use Trac to review "PR" branches. We write a ticket comment like this

Proposed changes in log:jomae.git@t13567 (1 commit)

This works fine for 1 or 2 commits, but for larger branches it is difficult to see (count) what commits are relevant.

Feature request: Allow somehow appending a parameter like ?commits=1-14:

Proposed changes in log:jomae.git@t13567?commits=1-14

This would be similar to the ?marks=1-14 appended by source:jomae.git/.github/workflows/build-completed.yml@t13567:1-14 and similarly highlight the first 14 commits / rows in the log table.

Attachments (0)

Change History (8)

comment:1 by anonymous, 20 months ago

log:jomae.git@27971c89:t13567 is an almost similar existing feature, but has downsides that make it unusable:

  • You have to lookup the start commit hash 27971c89.
  • You can not write e.g. log:jomae.git@t13567^14:t13567 and even that would be very inconvenient with the repeated branch name, especially when using longer branch names.
  • You don't see the other rows at all.

comment:3 by anonymous, 20 months ago

It doesn't work on our Trac. (No changeset trunk in the repository.) What is trunk there? Is it a Git concept? (We use Mercurial.)

comment:4 by Jun Omae, 20 months ago

Resolution: wontfix
Status: newclosed

You could use the following links:

Last edited 20 months ago by Jun Omae (previous) (diff)

comment:5 by anonymous, 20 months ago

Thanks for the feedback. &limit=... is a good option.

I still don't understand the trunk trick. What is trunk there? Is it Git specific? Is there a Mercurial equivalent? Thanks.

in reply to:  5 comment:6 by Jun Omae, 20 months ago

I still don't understand the trunk trick. What is trunk there? Is it Git specific? Is there a Mercurial equivalent? Thanks.

No. That is not trick. Specify existent branches/tags/sha-hahses in your repository to branch1 and branch2 in log:<reponame>@<branch1>:<branch2>.

comment:7 by anonymous, 20 months ago

I see, thanks, so trunk is the branch name, specific to the SVN-converted-to-Git Trac repository that points to the start of the relevant changes.

For a pure Mercurial repository we would need revsets, log:<reponame>@<revset1>:<revset2>, but that doesn't seem to work.

in reply to:  7 comment:8 by Jun Omae, 20 months ago

For a pure Mercurial repository we would need revsets, log:<reponame>@<revset1>:<revset2>, but that doesn't seem to work.

Ah, that is probably caused by log view for Mercurial repository listing by integer revision numbers.

Relative issues: #13092, #13318

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.