Element factory doesn't convert underscores to hyphens for keyword arguments

[Jun Omae]

$ script='from trac import __version__ as v; from trac.util.html import tag
; print(v); print(tag.span("", data_name="value"))'
$ ~/venv/trac/1.0.20/bin/python -c "$script"
1.0.20
<span data-name="value"></span>
$ ~/venv/trac/1.4.3/bin/python -c "$script"
1.4.3
<span data_name="value"></span>
$ ~/venv/trac/1.5.4/bin/python -c "$script"
1.5.4
<span data_name="value"></span>

Patch:

trac/util/html.py

@@ -431 +431 @@
             if v is not None:
                 if k[-1:] == '_':
                     k = k[:-1]
+                if '_' in k:
+                    k = k.replace('_', '-')
                 v = self._attr_value(k, v)
                 if v is not None:
                     attrs.append((k, escape(v)))

Workaround is passing a dict with names converted to hyphens:

$ script='from trac import __version__ as v; from trac.util.html import tag
; print(v); print(tag.span("", **{"data-name": "value"}))'
$ ~/venv/trac/1.0.20/bin/python -c "$script"
1.0.20
<span data-name="value"></span>
$ ~/venv/trac/1.4.3/bin/python -c "$script"
1.4.3
<span data-name="value"></span>
$ ~/venv/trac/1.5.4/bin/python -c "$script"
1.5.4
<span data-name="value"></span>

[Jun Omae]

I noticed another incompatible behavior with Genshi builder, while reading ​https://github.com/edgewall/genshi/blob/0.7.7/genshi/builder.py#L159-L163.

Genshi builder strips all trailing _ characters from attribute names, however tag builder in Trac 1.4+ strips only one _ character.

$ script='from trac import __version__ as v
from trac.util.html import tag
print(v)
print(tag.a("anchor", class__="data:"))'
$ ~/venv/trac/1.0.20/bin/python -c "$script"
1.0.20
<a class="data:">anchor</a>
$ ~/venv/trac/1.4.3/bin/python -c "$script"
1.4.3
<a class_="data:">anchor</a>
$ ~/venv/trac/1.5.4/bin/python -c "$script"
1.5.4
<a class_="data:">anchor</a>

[Ryan J Ollos]

Milestone renamed