Edgewall Software
Modify

Opened 21 months ago

Closed 19 months ago

Last modified 19 months ago

#13501 closed defect (fixed)

Codespell output

Reported by: figaro Owned by: figaro
Priority: low Milestone: 1.4.4
Component: general Version:
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Corrected misspellings in code comments.

Description

Some codespell output leading to the following suggested changes:

sed -i 's/explicitely/explicitly/' mirror/tracopt/perm/authz_policy.py
sed -i 's/explict/explicit/' mirror/trac/ticket/report.py
sed -i 's/Purposedly/Purposely/' mirror/tracopt/versioncontrol/svn/svn_fs.py
sed -i 's/preceeding/preceding/' mirror/tracopt/versioncontrol/svn/svn_fs.py
sed -i 's/preceeded/preceded/' mirror/trac/wiki/tests/wiki-tests.txt
sed -i 's/preceed/precede/' mirror/trac/dist.py
sed -i 's/wll returns/returns/' mirror/trac/config.py
sed -i 's/messsage/message/' mirror/trac/dist.py
sed -i 's/challange/challenge/' mirror/trac/web/auth.py
sed -i 's/succesful/successful/' mirror/trac/web/tests/auth.py
sed -i 's/absense/absence/' mirror/trac/tests/functional/better_twill.py
sed -i 's/non-existant/non-existent/' mirror/trac/util/autoreload.py
sed -i 's/infered/inferred/' mirror/trac/mimeview/api.py
sed -i 's/supress/suppress/' mirror/doc/utils/epydoc.conf
sed -i 's/inclue/include/' mirror/doc/utils/epydoc.conf
sed -i 's/includea/include/' mirror/doc/utils/epydoc.conf
sed -i 's/utilies/utilities/' mirror/doc/api/trac_util.rst
sed -i 's/authentification/authentication/' mirror/doc/api/trac_web_api.rst
sed -i 's/litteral/literal/' mirror/doc/api/trac_db_util.rst

The above impacts comments only. The result is attached.

This is the only code-impact: grep -nr assocations mirror/trac/mimeview/api.py

To apply change: sed -i 's/assocations/associations/' mirror/trac/mimeview/api.py

Then a note about 'overriden'. Not sure about the effect it will have on translations:

mirror/trac/timeline/web_ui.py:65: overriden  ==> overridden
mirror/trac/util/text.py:48: overriden  ==> overridden

See output of grep -nr overriden * Does it require a change in the code and the transifex lines will follow automatically? If so, these transifex lines will probably have to be reviewed?

Attachments (1)

mirror.diff (8.9 KB ) - added by figaro 21 months ago.
diff -ur mirror as result of Codespell

Download all attachments as: .zip

Change History (6)

by figaro, 21 months ago

Attachment: mirror.diff added

diff -ur mirror as result of Codespell

comment:1 by Ryan J Ollos, 21 months ago

Milestone: 1.4.4
Owner: set to Ryan J Ollos
Status: newassigned

comment:2 by Ryan J Ollos, 19 months ago

Internal Changes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.4-stable in r17606, merged to trunk in r17607.

comment:3 by Ryan J Ollos, 19 months ago

Owner: changed from Ryan J Ollos to figaro

comment:4 by Ryan J Ollos, 19 months ago

Then a note about 'overriden'. Not sure about the effect it will have on translations:

Yes, will correct those and extract the new catalogs.

in reply to:  4 comment:5 by Ryan J Ollos, 19 months ago

Replying to Ryan J Ollos:

Then a note about 'overriden'. Not sure about the effect it will have on translations:

Yes, will correct those and extract the new catalogs.

Fixed on 1.4-stable in r17608, merged to trunk in r17609.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain figaro.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from figaro to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.