ImportError: cannot import name 'contextfilter' from 'jinja2'

[Ryan J Ollos]

$ pip list | grep Jinja
Jinja2                        3.1.1

Traceback (most recent call last):
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/contrib/checkwiki.py", line 22, in <module>
    from trac.test import EnvironmentStub, Mock, MockPerm
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/test.py", line 47, in <module>
    from trac.env import Environment
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/env.py", line 52, in <module>
    from trac.web.chrome import Chrome
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/web/chrome.py", line 40, in <module>
    from trac.mimeview.api import RenderingContext, get_mimetype
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/mimeview/__init__.py", line 14, in <module>
    from trac.mimeview.api import *
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/mimeview/api.py", line 70, in <module>
    from trac.resource import Resource
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/resource.py", line 21, in <module>
    from trac.util.presentation import classes
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/presentation.py", line 24, in <module>
    from jinja2 import Undefined, contextfilter, evalcontextfilter
ImportError: cannot import name 'contextfilter' from 'jinja2' (/Users/rjollos/.pyenv/versions/trac-py310/lib/python3.10/site-packages/jinja2/__init__.py)
make: *** [update-help] Error 1

[anonymous]

​https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0

• Drop support for Python 3.6.
• Remove previously deprecated code.
  • contextfilter and contextfunction are replaced by pass_context.
  • …

[Jun Omae]

Changing milestone to 1.5.x because Jinja2 doesn't support Python 2.7 since 3.0.0.

[Jun Omae]

Verified unit tests passing with:

• Jinja2 3.1.1 on Python 3.9
• Jinja2 3.0.1 on Python 3.6, 3.7 and 3.8
• Jinja2 2.11.3 on Python 3.5

trac/util/presentation.py

@@ -21 +21 @@
 from math import ceil
 import re
 
-from jinja2 import Undefined, contextfilter, evalcontextfilter
+from jinja2 import Undefined
 from jinja2.filters import make_attrgetter
+try:
+    from jinja2 import pass_context, pass_eval_context
+except ImportError:
+    from jinja2 import (contextfilter as pass_context,
+                        evalcontextfilter as pass_eval_context)
 
 from trac.core import TracError
 from .datefmt import to_utimestamp, utc
@@ -72 +77 @@
 
 # -- Jinja2 custom filters
 
-@evalcontextfilter
+@pass_eval_context
 def htmlattr_filter(_eval_ctx, d, autospace=True):
     """Create an SGML/XML attribute string based on the items in a dict.
 
@@ -259 +264 @@
         yield tuple(buf)
 
 
-@contextfilter
+@pass_context
 def groupattr_filter(_eval_ctx, iterable, num, attr, *args, **kwargs):
     """Similar to `group`, but as an attribute filter."""
     attr_getter = make_attrgetter(_eval_ctx.environment, attr)

[Ryan J Ollos]

That looks good, thank you!

[Jun Omae]

Thanks for the review! Pushed in [17591].