query web UI broken after using OR condition

[Clemens]

Summary

In the query web UI the "And field" will be lost when using (and removing) a logical OR condition.

Eventually we have a situation where the query web UI has become unuseable. It is impossible to add new query conditions because all "And field" drop-down boxes are lost.

Reproduce

Tested with TRAC demo site (running TRAC 1.4.3). This is how to reproduce:

1. Create a custom ticket query with an OR condition:
   https://trac.edgewall.org/demo-1.4/query?status=accepted&or&resolution=fixed&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=milestone&order=priority
2. click the "MINUS" button to remove the second condition:
   
3. click the "MINUS" button to remove the other condition:
   
4. Problem! All "And field" drop-down boxes are lost:
   

TRAC versions

This seems to be a regression in a new TRAC version. Comparing the differences between different we can see that in TRAC 1.4 there seem to be one "And field" missing.

• TRAC 1.4:
  
• TRAC 1.2:
  
• TRAC 1.0:
  

[Clemens]

reproduce step 1

[Clemens]

reproduce step 2

[Clemens]

reproduce step 3

[Clemens]

TRAC 1.0 is not affected

[Clemens]

TRAC 1.2 is not affected

[Clemens]

TRAC 1.4 is affected

[Jun Omae]

Thanks for the reporting! I guess accidents occurs while porting query.html from Genshi template to Jinja2 template.

[Jun Omae]

Proposed changes in [ccc394b13/jomae.git] (jomae.git@t13455).

Before the patch:

$ curl -s 'https://trac.edgewall.org/demo-1.2/query?status=accepted&or&resolution=fixed&or&owner=$USER' | grep -w And
                         <label for="add_filter_0">And</label> 
                         <label for="add_filter_1">And</label> 
                         <label for="add_filter_2">And</label> 
$ curl -s 'https://trac.edgewall.org/demo-1.4/query?status=accepted&or&resolution=fixed&or&owner=$USER' | grep -w And
                          &nbsp;<label for="add_filter_2">And</label>&nbsp;

After the patch:

$ curl -s 'http://127.0.0.1:3000/1.4-sqlite/query?status=accepted&or&resolution=fixed&or&owner=$USER' | grep -w And
                          &nbsp;<label for="add_filter_0">And</label>&nbsp;
                          &nbsp;<label for="add_filter_1">And</label>&nbsp;
                          &nbsp;<label for="add_filter_2">And</label>&nbsp;

[Jun Omae]

Fixed in [17580] and merged in [17581].