Edgewall Software
Modify

Opened 4 years ago

Last modified 5 months ago

#13311 assigned enhancement

Toolbar button to quote text as a discussion citation

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Milestone: 1.6.1
Component: general Version:
Severity: normal Keywords:
Cc: trac@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

All Trac text input fields (like this ticket description field) have a little toolbar with buttons to make text bold or italic, insert a heading, a link, a code block, a horizontal rule, a new paragraph, a line break or an image.

It would be useful to have an additional button to quote the currently selected text as DiscussionCitations by adding > before each selected line.

Attachments (2)

edit_toolbar_T13311.png (1.0 KB ) - added by anonymous 4 years ago.
trac_wikibuttonbar.png (42.1 KB ) - added by anonymous 5 months ago.
screenshot of re-designed button bar

Download all attachments as: .zip

Change History (15)

comment:1 by Ryan J Ollos, 4 years ago

Milestone: next-major-releases

comment:2 by Ryan J Ollos, 4 years ago

The JavaScript code would be fairly simple, but it looks like the image edit_toolbar.png needs to be modified.

by anonymous, 4 years ago

Attachment: edit_toolbar_T13311.png added

comment:3 by anonymous, 4 years ago

Would this work?

The last two icons could be used for (de-)indenting the selected block of text (or the current line) by two spaces as required for example for WikiFormatting nested lists, block quotes, or for adjusting code snippets.

comment:4 by anonymous, 4 years ago

th:TextareaKeyBindingsPlugin has Javascript code for (de-)indent. Adding "> " + with indentation delta 0 should also be easy. But adding the buttons would be better in Trac core.

comment:5 by Ryan J Ollos, 4 years ago

Milestone: next-major-releases1.4.3
Owner: set to Ryan J Ollos
Status: newassigned

Looks good. Thanks!

comment:6 by anonymous, 4 years ago

I wondered if there's a common keyboard shortcut, but apparently not:

Button icon Keyboard shortcut
CKEditor -
Gitlab -
Github |= -
Slack |= Ctrl+Shift+9
Stackoverflow Ctrl+Q
TinyMCE - -
Wordpress Shift+Alt+Q

in reply to:  4 comment:7 by Ryan J Ollos, 4 years ago

Replying to anonymous:

th:TextareaKeyBindingsPlugin has Javascript code for (de-)indent.

I'm interested in eventually integrating this plugin to Trac. It might be a good project for someone that wants to get involved.

Trac allows tabbing to navigate form fields, which is standard behavior for web forms. If integrating the plugin, we'd need a way to preserve that behavior such as:

  • Using a key or key combination other than tab for indent/dedent.
  • Having vim-like behavior to toggle between normal (where tab moves to next field) and edit mode (where tab is input to textarea).
Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:8 by Ryan J Ollos, 3 years ago

Milestone: 1.4.31.5.3

comment:9 by Ryan J Ollos, 3 years ago

Milestone: 1.5.31.5.4

comment:10 by Ryan J Ollos, 3 years ago

Milestone: 1.5.41.5.5

comment:11 by Ryan J Ollos, 16 months ago

Milestone: 1.5.51.6.1

comment:12 by anonymous, 5 months ago

For my TRAC (1.6) instance I have recently completely rewritten the toolbar code. I call it "wiki buttonbar". Similarities and advantages compared with the "Wiki Toolbar" are as follows:

  • The old and the new toolbar are written in JavaScript (plus some CSS). Because they operate on client-side (in the web-browser) they do not depend on any server-side TRAC Python code.
  • In the new toolbar each toolbar button is independent from all others. In particular each of the new buttons has its own icon graphics. In the old toolbar all icons are collected in one big compound graphics file.
  • Because in the new toolbar buttons are independent it is easier to add new, deleted or rearrange buttons. It is not required to manually calculate pixel offsets and edit CSS anymore.
  • Adding a new toolbar button is as easy as adding one line of JavaScript code. CSS changes not needed.
  • In the new toolbar the icon graphic files can be SVG, PNG or any other browser image format.
  • The new toolbar offers optional drop-down sub-menus.
  • The new toolbar supports multi-line text manipulation, for example to intend a whole text block.
  • The new toolbar supports regular expressions for advanced text manipulation.
  • The new toolbar supports customized JavaScript tool functions. This may be used for cases where regular expressions are not sufficient e.g. table operations.
  • The new toolbar can provide all actions of the old one - and more. If really desired it could imitate the old look & feel.

Screenshot:
screenshot of re-designed button bar

If there is some basic interest from the TRAC developer team I can offer my code. Just tell me what you think …

Best regards Clemens

by anonymous, 5 months ago

Attachment: trac_wikibuttonbar.png added

screenshot of re-designed button bar

comment:13 by Clemens, 5 months ago

Cc: trac@… added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain Ryan J Ollos.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.