Edgewall Software

Opened 4 years ago

Last modified 4 years ago

#13308 closed defect

Fix styling warning in code.css — at Version 5

Reported by: figaro Owned by:
Priority: normal Milestone: 1.4.3
Component: general Version: 1.4
Severity: minor Keywords: patch css
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Jun Omae)

As per https://jigsaw.w3.org/css-validator/:

Family names containing whitespace should be quoted. 
If quoting is omitted, any whitespace characters before and after the name are ignored and any sequence of whitespace characters inside the name is converted to a single space. 

Change History (10)

by figaro, 4 years ago

Attachment: code.diff added

Code.css patch

comment:1 by Ryan J Ollos, 4 years ago

It's said to be good practice, but doesn't matter in practice: SO:7638833/121694.

If we are going to make the change, trac.css also needs changes. Also we don't want to add whitespace between comma-separated values because we consistently do otherwise throughout the CSS.

Patches should be prepared per TracDev/SubmittingPatches.

comment:2 by figaro, 4 years ago

Agreed, and renewed diffs have been created and attached. The command diff -u was used to generate these files as per TracDev/SubmittingPatches#Makethepatch, so unclear on how the patch is in deviation of the procedure.

by figaro, 4 years ago

Attachment: code.2.diff added

Unified diff of code.css stylesheet

by figaro, 4 years ago

Attachment: trac.diff added

Unified diff of trac.css stylesheet

in reply to:  2 comment:3 by Ryan J Ollos, 4 years ago

Replying to figaro:

so unclear on how the patch is in deviation of the procedure.

If you diff from root of repository you can create a single-file patch with embedded paths. The single-file patch is easier to apply.

Edited TracDev/SubmittingPatches@25.

comment:4 by figaro, 4 years ago

Severity: normalminor

by figaro, 4 years ago

Attachment: code.3.diff added

Unified diff of code.css stylesheet

by figaro, 4 years ago

Attachment: trac.2.diff added

Unified diff of trac.css stylesheet

comment:5 by Jun Omae, 4 years ago

Component: web frontendgeneral
Description: modified (diff)
Keywords: css added
Milestone: next-stable-1.4.x
Type: taskdefect
Version: 1.4

The issue exists in code.css, diff.css and trac.css files since Trac 1.4+. Also, font-family for sans serif has the same.

$ git grep 'font:\|font-family:' mirror/1.4-stable -- 'trac/**/*.css' | sed -e 's/:  */: /g' | sort -u
mirror/1.4-stable:trac/htdocs/css/admin.css:.trac-name { font-family: monospace; }
mirror/1.4-stable:trac/htdocs/css/browser.css: font-family: monospace;
mirror/1.4-stable:trac/htdocs/css/code.css: font-family: Open Sans Mono,Consolas,Lucida Console,monospace; /* code_monospace */
mirror/1.4-stable:trac/htdocs/css/diff.css: font-family: Open Sans Mono,Consolas,Lucida Console,monospace; /* code_monospace */
mirror/1.4-stable:trac/htdocs/css/jquery-ui/jquery-ui.css:      font-family: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif;
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: Open Sans Mono,Consolas,Lucida Console,monospace; /* code_monospace */
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: Roboto,Segoe UI,Verdana,'Bitstream Vera Sans',Helvetica,sans-serif; /* trac_sans_serif */
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: inherit;
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: sans-serif;
Note: See TracTickets for help on using tickets.