Fix styling warning in stylesheets

[figaro]

As per ​https://jigsaw.w3.org/css-validator/:

Family names containing whitespace should be quoted. 
If quoting is omitted, any whitespace characters before and after the name are ignored and any sequence of whitespace characters inside the name is converted to a single space. 

[figaro]

Code.css patch

[Ryan J Ollos]

It's said to be good practice, but doesn't matter in practice: ​SO:7638833/121694.

If we are going to make the change, trac.css​ also needs changes. Also we don't want to add whitespace between comma-separated values because we consistently do otherwise throughout the CSS.

Patches should be prepared per TracDev/SubmittingPatches.

[figaro]

Agreed, and renewed diffs have been created and attached. The command diff -u was used to generate these files as per TracDev/SubmittingPatches#Makethepatch, so unclear on how the patch is in deviation of the procedure.

[figaro]

Unified diff of code.css stylesheet

[figaro]

Unified diff of trac.css stylesheet

[Ryan J Ollos]

Replying to figaro:

so unclear on how the patch is in deviation of the procedure.

If you diff from root of repository you can create a single-file patch with embedded paths. The single-file patch is easier to apply.

Edited TracDev/SubmittingPatches@25.

[figaro]

Unified diff of code.css stylesheet

[figaro]

Unified diff of trac.css stylesheet

[Jun Omae]

The issue exists in code.css, diff.css and trac.css files since Trac 1.4+. Also, font-family for sans serif has the same.

$ git grep 'font:\|font-family:' mirror/1.4-stable -- 'trac/**/*.css' | sed -e 's/:  */: /g' | sort -u
mirror/1.4-stable:trac/htdocs/css/admin.css:.trac-name { font-family: monospace; }
mirror/1.4-stable:trac/htdocs/css/browser.css: font-family: monospace;
mirror/1.4-stable:trac/htdocs/css/code.css: font-family: Open Sans Mono,Consolas,Lucida Console,monospace; /* code_monospace */
mirror/1.4-stable:trac/htdocs/css/diff.css: font-family: Open Sans Mono,Consolas,Lucida Console,monospace; /* code_monospace */
mirror/1.4-stable:trac/htdocs/css/jquery-ui/jquery-ui.css:      font-family: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif;
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: Open Sans Mono,Consolas,Lucida Console,monospace; /* code_monospace */
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: Roboto,Segoe UI,Verdana,'Bitstream Vera Sans',Helvetica,sans-serif; /* trac_sans_serif */
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: inherit;
mirror/1.4-stable:trac/htdocs/css/trac.css: font-family: sans-serif;

[figaro]

Understood what is meant by single file patch.

[figaro]

Single file patch for styling guideline

[figaro]

Added Segoe UI, supersedes attachment with similar name

[Ryan J Ollos]

Replying to Jun Omae:

Also, font-family for sans serif has the same.

​W3C says sans-serif must not be quoted.

[Jun Omae]

Replying to Ryan J Ollos:

Replying to Jun Omae:

Also, font-family for sans serif has the same.

​W3C says sans-serif must not be quoted.

Sorry for the unclear.

That means Segoe UI should be quoted at /* trac_sans_serif */ line in trac/htdocs/css/trac.css.

-font-family: Roboto,Segoe UI,Verdana,'Bitstream Vera Sans',Helvetica,sans-serif; /* trac_sans_serif */
+font-family: Roboto,'Segoe UI',Verdana,'Bitstream Vera Sans',Helvetica,sans-serif; /* trac_sans_serif */

The change is included in attachment:trac-1.4.1.2.diff​.

[Ryan J Ollos]

Thanks for clarification.

Committed to 1.4-stable in r17451, merged in r17452.