Edgewall Software
Modify

Opened 2 years ago

Closed 2 years ago

#13306 closed defect (wontfix)

db41 should not write [mainnav] and [metanav] if sections defined in inherited config

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone:
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

If [trac] mainnanv and/or metanav are defined in an inherited trac.ini, then the db41 upgrade should not write [mainnav] and [metanav] to the environment trac.ini. Instead, a message should be printed instructing the user to migrate the sections to the new format.

gmessage:trac-users:jkXZjagyBBU/hHiQ1iJOCwAJ

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 2 years ago

Description: modified (diff)

comment:2 by Ryan J Ollos, 2 years ago

A few things would be needed:

  • Determine which parser has the value of a configuration option.
  • Test if that parser is writable.
    • If yes, write to that configuration file.
    • If no, print to terminal that the user will need to manually upgrade, or just write to primary config file and print a message informing the user.

I'm debating whether to fix this at all or just add a note to TracUpgrade. In that case, some of these action items for config.py module improvements could be added to #3037.

comment:3 by Ryan J Ollos, 2 years ago

Milestone: 1.2.6
Resolution: wontfix
Status: assignedclosed

Since inherited ini files are often shared by Trac environments we shouldn't write to any inherited ini file. If we were to do so, we'd need to add a configuration option to say whether the file is writable, and additional complexity would be needed in the Configuration class.

Added documentation:

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.