Edgewall Software
Modify ↓

Opened 4 years ago

Closed 4 years ago

#13303 closed enhancement (fixed)

Move prefs panel help to bottom of page

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.4.2
Component: notification Version:
Severity: normal Keywords: preferences
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

The preferences pages have repositioned the trac-help div below the submit button and improved layout when child notification panels are present.

Description (last modified by Ryan J Ollos)

Found while investigating #1660. This places the help below child panels.

→

Also, I think we can have /prefs/notification use the default submit button.

Attachments (4)

Screen Shot 2020-05-20 at 16.15.58.jpg​ (19.8 KB ) - added by Ryan J Ollos 4 years ago.
Screen Shot 2020-05-20 at 16.16.33.jpg​ (19.7 KB ) - added by Ryan J Ollos 4 years ago.
Screen Shot 2020-05-20 at 16.23.40.jpg​ (66.0 KB ) - added by Ryan J Ollos 4 years ago.
Screen Shot 2020-05-20 at 16.24.00.jpg​ (68.1 KB ) - added by Ryan J Ollos 4 years ago.

Download all attachments as: .zip

Change History (9)

by Ryan J Ollos, 4 years ago

Attachment: Screen Shot 2020-05-20 at 16.15.58.jpg​ added

by Ryan J Ollos, 4 years ago

Attachment: Screen Shot 2020-05-20 at 16.16.33.jpg​ added

comment:1 by Ryan J Ollos, 4 years ago

Description: modified (diff)
Keywords: preferences added
Owner: set to Ryan J Ollos
Status: new → assigned

by Ryan J Ollos, 4 years ago

Attachment: Screen Shot 2020-05-20 at 16.23.40.jpg​ added

by Ryan J Ollos, 4 years ago

Attachment: Screen Shot 2020-05-20 at 16.24.00.jpg​ added

comment:2 by Ryan J Ollos, 4 years ago

→

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:3 by Ryan J Ollos, 4 years ago

Internal Changes: modified (diff)

Proposed changes: log:rjollos.git:t13303_prefs_panel. The make jinja checks pass.

It works with JavaScript disabled. The Save button next to Email format was removed, previously active when JavaScript is disabled. I don't think functionality without JavaScript is so important these days, and possibly better anyway to use the same Submit button w/ and w/o JavaScript.

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:4 by Ryan J Ollos, 4 years ago

Description: modified (diff)

comment:5 by Ryan J Ollos, 4 years ago

Resolution: → fixed
Status: assigned → closed

I moved the trac-help div outside the form.

Committed to 1.4-stable in r17372, merged to trunk in r17373.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.