Skip ITicketManipulator.validate_comment when creating ticket

[Ryan J Ollos]

comment is always None when creating a ticket, so the interface method can be skipped.

trac/ticket/api.py

@@ -166 +166 @@
         compatibility."""
 
     def validate_ticket(req, ticket):
-        """Validate a ticket after it's been populated from user input.
+        """Validate ticket properties when creating or modifying.
 
         Must return a list of `(field, message)` tuples, one for each problem
         detected. `field` can be `None` to indicate an overall problem with the
         ticket. Therefore, a return value of `[]` means everything is OK."""
 
     def validate_comment(req, comment):
-        """Validate ticket comment after it has been edited.
+        """Validate ticket comment when appending or editing.
 
         Must return a list of messages, one for each problem detected.
         The return value `[]` indicates no problems.

trac/ticket/web_ui.py

@@ -1330 +1330 @@
         # Validate custom rules.
         comment = comment or req.args.get('edited_comment')
         for manipulator in self.ticket_manipulators:
-            if hasattr(manipulator, 'validate_comment'):
+            if ticket.exists and hasattr(manipulator, 'validate_comment'):
                 for message in manipulator.validate_comment(req, comment):
                     valid = False
                     add_warning(req, tag_("The ticket comment is invalid: "

[Ryan J Ollos]

Proposed changes in [b1b368d9c/rjollos.git].

[Ryan J Ollos]

Committed to 1.4-stable in r17328, merged to trunk in r17329.