Add a "trac-admin session rename" command

[Ryan J Ollos]

The session rename command would be particularly useful if it updates table entries that store the sid.

[Ryan J Ollos]

Milestone renamed

[Niklas <niklap97@…>]

I'll take a look. Which parameters should the function get?

[Ryan J Ollos]

Replying to Niklas <niklap97@…>:

I'll take a look. Which parameters should the function get?

I was thinking very simply:

$ trac-admin $env session rename <old-sid> <new-sid>

[Niklas <niklap97@…>]

here a suggestion for the session_rename function.

[Ryan J Ollos]

It's a good start! There are a bunch of other tables that use the sid as well: TracDev/DatabaseSchema#DatabaseSchemaTrac0.12. Those also need to be updated. For example, wiki.author.

[Niklas <niklap97@…>]

Thanks for the feedback! However, I don't quite understand why wiki.authorshould be updated, because the sid attribute is only located in session and session_attribute. Sorry for the inconvenience.

[Ryan J Ollos]

When you save a change to a wiki page the sid is stored in the wiki.author table. The intent of the rename command is to change all instances of sid that are stored in the database. The instances of sid are often stored in a column of a different name, such as author.

For example, the sid is retrieved from req.session, which is used to populate the author field when saving a change:

• tags/trac-1.5.3/trac/wiki/web_ui.py@:370#L358​
• tags/trac-1.5.3/trac/util/__init__.py#L45​

[Jun Omae]

Considering the feature and the proposed patch:

• notify_subscription and notify_watch tables have sid and authenticated columns. See source:/trunk/trac/db_default.py@17593#/sid​
• The renaming should be blocked if the new sid is already used, I think.

[Niklas <niklap97@…>]

Replying to Ryan J Ollos:

When you save a change to a wiki page the sid is stored in the wiki.author table. The intent of the rename command is to change all instances of sid that are stored in the database. The instances of sid are often stored in a column of a different name, such as author.

For example, the sid is retrieved from req.session, which is used to populate the author field when saving a change:

• tags/trac-1.5.3/trac/wiki/web_ui.py@:370#L358​
• tags/trac-1.5.3/trac/util/__init__.py#L45​

Thanks for the quick answer. but in wiki.author in the data base, the name and/or the e-mail is stored and not the sid, right?

[Niklas <niklap97@…>]

Replying to Jun Omae:

Considering the feature and the proposed patch:

• notify_subscription and notify_watch tables have sid and authenticated columns. See source:/trunk/trac/db_default.py@17593#/sid​
• The renaming should be blocked if the new sid is already used, I think.

Thanks, will be added.

[Niklas <niklap97@…>]

Added: update notify tables + check if sid is already taken

[Ryan J Ollos]

Replying to Niklas <niklap97@…>:

Thanks for the quick answer. but in wiki.author in the data base, the name and/or the e-mail is stored and not the sid, right?

Need to confirm, but I believe for authenticated users the sid is stored.