Edgewall Software
Modify

Opened 5 years ago

Closed 5 years ago

#13256 closed defect (invalid)

Permission policies not changed upgrading from Trac < 1.2

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone:
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

Discussed in gmessage:trac-users:z3nTgHPbBaw/T30q9SKgAgAJ. Instead of comparing permission_policies to the Trac 1.2 default value, we should look at the entries in the list and be more flexible in deciding whether to automatically upgrade.

Attachments (0)

Change History (3)

comment:1 by Ryan J Ollos, 5 years ago

Description: modified (diff)

comment:2 by Peter Suter, 5 years ago

upgrades/db30.py (#11244) auto-upgrades from the old default:

[trac]
permission_policies = DefaultPermissionPolicy,LegacyAttachmentPolicy

To:

[trac]
permission_policies = ReadonlyWikiPolicy, DefaultPermissionPolicy,LegacyAttachmentPolicy

And upgrades/db43.py (#12719) auto-upgrades from that to:

[trac]
permission_policies = DefaultWikiPolicy, DefaultTicketPolicy, DefaultPermissionPolicy,LegacyAttachmentPolicy

But the reported case still had:

[trac]
permission_policies = DefaultPermissionPolicy,LegacyAttachmentPolicy

The upgrades do print information about manually adding the new policies.

comment:3 by Ryan J Ollos, 5 years ago

Milestone: 1.4.2
Resolution: invalid
Status: assignedclosed

Thanks for investigating, I had forgotten about db30.py. The reporter confirmed that he overwrote trac.ini from 1.4 with trac.ini from 1.0, thereby causing the problem.

I suppose we could handle permission_policies = LegacyAttachmentPolicy,DefaultPermissionPolicy, but not sure that is needed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.