Edgewall Software
Modify ↓

Opened 5 years ago

Closed 5 years ago

#13198 closed defect (fixed)

Link to RSS feed in query page should be `/login?referer=...` for authenticated users

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.0.19
Component: query system Version: 1.0-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:
  • Modified a link to RSS feed in query page to redirect through /login for authenticated users.
  • Made a link to RSS feed a first link in alternate links in ticket page.
API Changes:
Internal Changes:

Description

The links to RSS feed have been modified to redirect through /login in r10346 (#540), however the link in query view not modified.

Attachments (0)

Change History (6)

comment:1 by Jun Omae, 5 years ago

Owner: set to Jun Omae
Status: new → assigned

Proposed changes in [609a7cd93/jomae.git].

comment:2 by Jun Omae, 5 years ago

Minor thing: a link to RSS feed in ticket page is last entry, however the link in other pages is first entry, inconsistently….

in reply to:  2 comment:3 by Ryan J Ollos, 5 years ago

Proposed changes look good to me.

Replying to Jun Omae:

Minor thing: a link to RSS feed in ticket page is last entry, however the link in other pages is first entry, inconsistently….

Nice find. I favor fixing it.

  • trac/ticket/tests/conversion.py 

    diff --git a/trac/ticket/tests/conversion.py b/trac/ticket/tests/conversion.py
index 5fecff8ab..7438063f2 100644
    a b class TicketConversionTestCase(unittest.TestCase):  
    6363    def test_conversions(self):
    6464        conversions = self.mimeview.get_supported_conversions(
    6565            'trac.ticket.Ticket')
    66         expected = sorted([('csv', 'Comma-delimited Text', 'csv',
    67                            'trac.ticket.Ticket', 'text/csv', 8,
    68                            self.ticket_module),
    69                           ('tab', 'Tab-delimited Text', 'tsv',
    70                            'trac.ticket.Ticket', 'text/tab-separated-values', 8,
    71                            self.ticket_module),
    72                            ('rss', 'RSS Feed', 'xml',
    73                             'trac.ticket.Ticket', 'application/rss+xml', 8,
    74                             self.ticket_module)],
    75                           key=lambda i: i[-1], reverse=True)
    76         self.assertEqual(expected, conversions)
     66        expected = [('rss', 'RSS Feed', 'xml',
     67                     'trac.ticket.Ticket', 'application/rss+xml', 8,
     68                     self.ticket_module),
     69                    ('csv', 'Comma-delimited Text', 'csv',
     70                     'trac.ticket.Ticket', 'text/csv', 8,
     71                     self.ticket_module),
     72                    ('tab', 'Tab-delimited Text', 'tsv',
     73                     'trac.ticket.Ticket', 'text/tab-separated-values', 8,
     74                     self.ticket_module)]
     75        self.assertEqual(expected, list(conversions))
    7776
    7877    def test_csv_conversion(self):
    7978        ticket = self._create_a_ticket()

  • trac/ticket/web_ui.py 

    diff --git a/trac/ticket/web_ui.py b/trac/ticket/web_ui.py
index 5555fa834..b76d8833a 100644
    a b class TicketModule(Component):  
    135135    # IContentConverter methods
    136136
    137137    def get_supported_conversions(self):
     138        yield ('rss', _("RSS Feed"), 'xml',
     139               'trac.ticket.Ticket', 'application/rss+xml', 8)
    138140        yield ('csv', _("Comma-delimited Text"), 'csv',
    139141               'trac.ticket.Ticket', 'text/csv', 8)
    140142        yield ('tab', _("Tab-delimited Text"), 'tsv',
    141143               'trac.ticket.Ticket', 'text/tab-separated-values', 8)
    142         yield ('rss', _("RSS Feed"), 'xml',
    143                'trac.ticket.Ticket', 'application/rss+xml', 8)
    144144
    145145    def convert_content(self, req, mimetype, ticket, key):
    146146        if key == 'csv':

comment:4 by Jun Omae, 5 years ago

Milestone: 1.2.6 → 1.0.19

Thanks for the reviewing.

I'd like to apply the changes to 1.0-stable which has the same issue: [9abdbadda/jomae.git] (jomae.git@t13198+1.0).

comment:5 by Jun Omae, 5 years ago

Release Notes: modified (diff)

[9abdbadda/jomae.git] has been committed in [17147] and merged in [17148-17150].

I will commit the patch in comment:3 soon. Thanks.

in reply to:  5 comment:6 by Jun Omae, 5 years ago

Resolution: → fixed
Status: assigned → closed

Replying to Jun Omae:

I will commit the patch in comment:3 soon. Thanks.

Committed in [17151] and merged in [17152-17154].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.