unit-test with de_DE.UTF8 locale is failing after r16959

[Jun Omae]

$ LC_ALL=de_DE.UTF8 make clean Trac.egg-info {unit,functional}-test
....
======================================================================
FAIL: Error is returned when a command is executed in interpreter
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jun66j5/src/tracdev/git/trac/admin/tests/console.py", line 224, in test_python_with_optimizations_returns_error
    stderr.strip())
  File "/home/jun66j5/src/tracdev/git/trac/admin/tests/console.py", line 175, in assertEqual
    output, diff()))
AssertionError: 'Python with optimizations is not supported.' != 'Python mit Optimierungen wird nicht unterst\xc3\xbctzt.'
--- expected
+++ actual
@@ -1,1 +1,1 @@
-Python with optimizations is not supported.
+Python mit Optimierungen wird nicht unterstützt.


----------------------------------------------------------------------
Ran 2412 tests in 69.956s

FAILED (failures=1)
Makefile:381: recipe for target 'unit-test' failed
make: *** [unit-test] Error 1

trac/admin/tests/console.py

@@ -213 +213 @@
         """Error is returned when a command is executed in interpreter
         with optimizations enabled.
         """
+        env = os.environ.copy()
+        env['LC_ALL'] = env['LANG'] = 'C'  # use en_US locale messages
         proc = Popen((sys.executable, '-O', '-m', 'trac.admin.console',
                       'help'), stdin=PIPE, stdout=PIPE, stderr=PIPE,
-                     close_fds=close_fds)
+                     close_fds=close_fds, env=env)
         stdout, stderr = proc.communicate(input='')
         for f in (proc.stdin, proc.stdout, proc.stderr):
             f.close()

[Ryan J Ollos]

I think it'd be okay to include in 1.2.4. I'll resume with the release process in about 8 hours.

[Jun Omae]

Okay. Committed in [16967].

[Jun Omae]

The issue comes back since [16969/branches/1.2-stable/trac/admin/tests/console.py].

[Jun Omae]

Fixed in [17073].