Edgewall Software
Modify

Opened 6 years ago

Closed 6 years ago

Last modified 9 months ago

#13141 closed defect (cantfix)

"Form Submission Failed" on /query on Chrome when adding filters

Reported by: Adam Johnson <me@…> Owned by:
Priority: normal Milestone:
Component: general Version:
Severity: normal Keywords: chrome
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Hi,

I got this error when trying to search for tickets on the Django Trac at https://code.djangoproject.com/query just now using the latest version of Chrome, 73. It also happens on Trac Trac ( https://trac.edgewall.org/query ).

After adding a filter, the form refuses to submit. Checking in the dev console I see the error message:

"Form submission failed, as the <SELECT> element named '0_description_mode' was implicitly closed by reaching the end of the file. Please add an explicit end tag ('</SELECT>')."

I checked and this does not happen in Firefox, my guess it's some new behaviour in Chrome.

I hacked around in the Chrome dev tools and found that modifying query.js to create the element with an extra '</select>' in its HTML, this stops occurring.

Attachments (2)

0001-Fix-issue-13141.patch (747 bytes ) - added by Adam Johnson <me@…> 6 years ago.
Patch
Screenshot 2019-03-31 at 10.34.50.png (428.8 KB ) - added by Adam Johnson <me@…> 6 years ago.
Screenshot of error

Download all attachments as: .zip

Change History (10)

by Adam Johnson <me@…>, 6 years ago

Attachment: 0001-Fix-issue-13141.patch added

Patch

by Adam Johnson <me@…>, 6 years ago

Screenshot of error

comment:1 by anonymous, 6 years ago

Here it's suggested to:

Go to chrome://flags/#enable-experimental-web-platform-features and click Disable.

And links to WhatWG.

comment:2 by Adam Johnson <me@…>, 6 years ago

Thanks, that fixed it for me. Did not even cross my mind that it could be an experimental feature, which I turned on a few weeks ago.

comment:3 by Jun Omae, 6 years ago

Milestone: undecided

Reproduced but the select element has </select>.

$('select[name=0_description_mode]').parent().parent().html()
"<td><div class="inlinebuttons"><input type="button" value="–"></div></td><th scope="row"><label id="label_0_description">Description</label></th><td class="mode"><select name="0_description_mode"><option value="~">contains</option><option value="!~">doesn't contain</option></select></td><td class="filter"><input type="text" name="0_description" size="42"></td>"

I believe that is a Chrome / Chromium issue. Please report Chrome or Chromium bug tracker. The experimental feature should be disabled.

comment:4 by Jun Omae, 6 years ago

Owner: Adam Johnson <me@…> removed
Status: assignednew

comment:5 by anonymous, 6 years ago

Keywords: chrome added

comment:7 by Ryan J Ollos, 6 years ago

Milestone: undecided
Resolution: cantfix
Status: newclosed

comment:8 by Weston Ruter, 9 months ago

I just encountered this issue on the WordPress Trac instance. I opened a ticket there as well.

I was able to fix the problem locally via Local Overrides in Chrome DevTools. I modified https://s.w.org/style/trac/common/js/query.js?v=216 by simply supplying the missing </select>:

44c44
<     var e = $($.htmlFormat('<select name="$1">', name));
---
>     var e = $($.htmlFormat('<select name="$1"></select>', name));

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.