Edgewall Software
Modify ↓

Opened 6 years ago

Closed 5 years ago

#13086 closed enhancement (fixed)

Workflow status change should be an explicit operation

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.5.1
Component: ticket system Version:
Severity: normal Keywords: workflow
Cc: Branch:
Release Notes:
API Changes:

The workflow state keywords <none> and < none > are substituted with None in parse_workflow_config.

Internal Changes:

Description (last modified by Ryan J Ollos)

Discussed in comment:7:ticket:13013 and comment:8:ticket:13013 are two ideas for improving the status change behavior:

  1. Move status change operation to trac/ticket/web_ui.py
  2. Add a set_status operation for explicitly controlling status changes.

Attachments (0)

Change History (9)

comment:1 by Jun Omae, 6 years ago

I think the set_status operation is redundant. When a new status of action is not *, that means setting a new status. Even thought a user don't specify set_status operation, we have to set the new status. 

accept = new,accepted -> accepted
accept.permissions = TICKET_MODIFY
accept.operations = set_owner_to_self

leave = * -> *
leave.operations = leave_status
leave.default = 1

comment:2 by Ryan J Ollos, 6 years ago

Feel free to propose a fix.

comment:3 by Ryan J Ollos, 5 years ago

Description: modified (diff)

comment:4 by Ryan J Ollos, 5 years ago

Milestone: 1.3.5
Resolution: → wontfix
Status: assigned → closed

I've explored some changes, but I have no definitive ideas for improving on the design.

comment:5 by Ryan J Ollos, 5 years ago

See related discussion in #13199.

comment:6 by Ryan J Ollos, 5 years ago

Milestone: → 1.5.1
Resolution: wontfix
Status: closed → reopened

Reopening to investigate moving ticket status change to trac.ticket.web_ui.TicketModule.get_ticket_changes (comment:2:ticket:13199).

comment:7 by Ryan J Ollos, 5 years ago

I found what I think is a better way to implement r16954. Proposed changes in log:rjollos.git:t13086_move_status_change.2.

comment:8 by Ryan J Ollos, 5 years ago

Status: reopened → assigned

comment:9 by Ryan J Ollos, 5 years ago

API Changes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed to trunk in r17169 and r17170.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.