Opened 7 years ago
Last modified 5 years ago
#13081 new defect
IWikiMacroProvider.is_inline should take macro name as argument
| Reported by: | Ryan J Ollos | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | next-dev-1.7.x |
| Component: | general | Version: | 1.0 |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
IWikiMacroProvider.is_inline was added in r10905.
Implementers of IWikiMacroProvider can define multiple macros, so the other interface methods take name as an argument. It would seem that is_inline should also take name as an argument since the different macros might produce different types of content.
Attachments (0)
Change History (6)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
I've thought the same thing. I consider that content and args parameters of expand_macro not only name parameter should be passed ([[TicketQuery(format=table)]] vs. [[TicketQuery(format=count)]]).
comment:3 by , 7 years ago
Or, it might be good to enhance expand_macro() to return a tuple of (content, is_block).
comment:4 by , 6 years ago
| Milestone: | next-major-releases → 1.5.1 |
|---|
comment:5 by , 6 years ago
| Milestone: | 1.5.1 → next-dev-1.5.x |
|---|



When this is fixed and deployed I can conclude work on the
TracReleasesmacro. In the meantime, edited TracDev/ReleaseChecklist@136.