Edgewall Software

Opened 17 months ago

Last modified 5 months ago

#13081 new defect

IWikiMacroProvider.is_inline should take macro name as argument

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone: next-dev-1.5.x
Component: general Version: 1.0
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:


IWikiMacroProvider.is_inline was added in r10905.

Implementers of IWikiMacroProvider can define multiple macros, so the other interface methods take name as an argument. It would seem that is_inline should also take name as an argument since the different macros might produce different types of content.

Attachments (0)

Change History (5)

comment:1 by Ryan J Ollos, 17 months ago

When this is fixed and deployed I can conclude work on the TracReleases macro. In the meantime, edited TracDev/ReleaseChecklist@136.

comment:2 by Jun Omae, 17 months ago

I've thought the same thing. I consider that content and args parameters of expand_macro not only name parameter should be passed ([[TicketQuery(format=table)]] vs. [[TicketQuery(format=count)]]).

comment:3 by Jun Omae, 17 months ago

Or, it might be good to enhance expand_macro() to return a tuple of (content, is_block).

comment:4 by Ryan J Ollos, 5 months ago

Milestone: next-major-releases1.5.1

comment:5 by Ryan J Ollos, 5 months ago

Milestone: 1.5.1next-dev-1.5.x

Modify Ticket

Change Properties
Set your email in Preferences
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.