Label of custom field should not be translated in ticket view

[Jun Omae]

After configuring the following, Due label is unintentionally translated in ticket view.

[ticket-custom]
duedate = text
duedate.label = Due

$ curl -s -H 'Accept-Language: en-us' http://127.0.0.1:3000/tracenv/newticket | grep -F ' for="field-duedate"'
                      <label for="field-duedate">Due:</label>
$ curl -s -H 'Accept-Language: de' http://127.0.0.1:3000/tracenv/newticket | grep -F ' for="field-duedate"'
                      <label for="field-duedate">Fällig:</label>
$ curl -s -H 'Accept-Language: ja' http://127.0.0.1:3000/tracenv/newticket | grep -F ' for="field-duedate"'
                      <label for="field-duedate">期日:</label>
$ curl -s -H 'Accept-Language: ko' http://127.0.0.1:3000/tracenv/newticket | grep -F ' for="field-duedate"'
                      <label for="field-duedate">완료 기한:</label>

I don't think a user is getting expected label by that behavior.

trac/ticket/api.py

@@ -308 +308 @@
         fields = copy.deepcopy(self.fields)
         label = 'label' # workaround gettext extraction bug
         for f in fields:
-            f[label] = gettext(f[label])
+            if not f.get('custom'):
+                f[label] = gettext(f[label])
         return fields
 
     def reset_ticket_fields(self):

[Ryan J Ollos]

The change looks good.

Regarding translation of ticket custom field labels, the only open ticket I see where it's discussed is #9648.

[Jun Omae]

I get unexpected translated label for Branch custom field here.

[Jun Omae]

Committed in [16836] and merged in [16837].