TracStandalone should check for existence of environment path(s)

[Ryan J Ollos]

Reported in ​gmessage:trac-users:vbxMYlLO1kA/S1yC0-zmCgAJ.

[Ryan J Ollos]

Proposed changes for trunk in [d8ff3e3d8/rjollos.git]. I'll prepare changes for 1.2-stable.

[Ryan J Ollos]

• log:rjollos.git:t13063_tracd_environment_path+1.2-stable
• log:rjollos.git:t13063_tracd_environment_path+trunk

[Jun Omae]

Testing the branch for 1.2-stable, value of --pidfile option is checked but error is not raised with non-existent file.

$ PYTHONPATH=. python -m trac.web.standalone --pidfile=/x.pid --port=3000 -e /
Server starting in PID 2988.
Serving on 0.0.0.0:3000 view at http://127.0.0.1:3000/
Using HTTP/1.1 protocol version

• parser.has_option('pidfile') should be parser.has_option('--pidfile')
• I don't think the pid file should be checked. The file normally is not existent before running tracd. It would be created if not existent.

-    if parser.has_option('pidfile') and options.pidfile:
-        options.pidfile = to_abspath(options.pidfile)
+    if parser.has_option('--pidfile') and options.pidfile:
+        options.pidfile = os.path.abspath(options.pidfile)

Another thing, I consider we should use %s for path parameter rather than %r, especially for Windows ('C:\\path\\to\\tracenv' is printed instead of 'C:\path\to\tracenv').

-            raise parser.error("Path does not exist: %r" % path)
+            raise parser.error("Path does not exist: '%s'" % path)

[Ryan J Ollos]

Thank you for review and suggestions.

Changes committed to 1.2-stable in r16830, merged to trunk in r16831 (and r16832).